Fix error SC2068 in shell scripts

Fix SC2068 (error): Double quote array expansions to avoid re-splitting elements.

https://www.shellcheck.net/wiki/SC2068

Author: xtqqczze

build.sh

@@ -13,4 +13,4 @@ while [[ -h $source ]]; do
 done
 
 scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
-"$scriptroot/eng/common/build.sh" --build --restore $@
+"$scriptroot/eng/common/build.sh" --build --restore "$@"

eng/common/SetupNugetSources.sh

@@ -164,7 +164,7 @@ fi
 
 DotNetVersions=('5' '6' '7' '8' '9' '10')
 
-for DotNetVersion in ${DotNetVersions[@]} ; do
+for DotNetVersion in "${DotNetVersions[@]}" ; do
     FeedPrefix="dotnet${DotNetVersion}";
     grep -i "<add key=\"$FeedPrefix\"" $ConfigFile > /dev/null
     if [ "$?" == "0" ]; then
@@ -181,7 +181,7 @@ PackageSources+=$(grep -oh '"darc-int-[^"]*"' $ConfigFile | tr -d '"')
 IFS=$PrevIFS
 
 if [ "$CredToken" ]; then
-    for FeedName in ${PackageSources[@]} ; do
+    for FeedName in "${PackageSources[@]}" ; do
         # Check if there is no existing credential for this FeedName
         grep -i "<$FeedName>" $ConfigFile 
         if [ "$?" != "0" ]; then

eng/common/cibuild.sh

@@ -13,4 +13,4 @@ while [[ -h $source ]]; do
 done
 scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
 
-. "$scriptroot/build.sh" --restore --build --test --pack --publish --ci $@
+. "$scriptroot/build.sh" --restore --build --test --pack --publish --ci "$@"

eng/common/cross/tizen-fetch.sh

@@ -8,7 +8,7 @@ fi
 Log()
 {
     if [ $VERBOSE -ge 1 ]; then
-        echo ${@:2}
+        echo "${@:2}"
     fi
 }
 
@@ -127,7 +127,7 @@ fetch_tizen_pkgs()
 
     PACKAGE_CHECKSUM_XPATH_TPL='string(//*[local-name()="metadata"]/*[local-name()="package"][*[local-name()="name"][text()="_PKG_"]][*[local-name()="arch"][text()="_ARCH_"]]/*[local-name()="checksum"]/text())'
 
-    for pkg in ${@:2}
+    for pkg in "${@:2}"
     do
         Inform "Fetching... $pkg"
         XPATH=${PACKAGE_XPATH_TPL/_PKG_/$pkg}

eng/common/pipeline-logging-functions.sh

@@ -36,7 +36,7 @@ function Write-PipelineTelemetryError {
   fi
   message="(NETCORE_ENGINEERING_TELEMETRY=$telemetry_category) $message"
   function_args+=("$message")
-  Write-PipelineTaskError ${function_args[@]}
+  Write-PipelineTaskError "${function_args[@]}"
 }
 
 function Write-PipelineTaskError {

eng/configure-toolset.sh

@@ -21,7 +21,7 @@ function Test-FilesUseTelemetryOutput {
 
     local file_list=`grep --files-without-match --recursive --include=*.sh "Write-PipelineTelemetryError" $scriptroot`
     for file in $file_list; do
-        for remove_file in ${require_telemetry_exclude_files[@]}; do
+        for remove_file in "${require_telemetry_exclude_files[@]}"; do
             if [[ $file =~ .*"$remove_file" ]]; then
             file_list=( "${file_list[@]/$file}" )
             fi

restore.sh

@@ -13,4 +13,4 @@ while [[ -h $source ]]; do
 done
 
 scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
-"$scriptroot/eng/common/build.sh" --restore $@
+"$scriptroot/eng/common/build.sh" --restore "$@"

src/Microsoft.DotNet.Build.Tasks.Installers/build/deb-package-tool/package_tool.sh

@@ -186,7 +186,7 @@ package_absolute_placement(){
         abs_files=( $(_get_files_in_dir_tree $ABSOLUTE_PLACEMENT_DIR) )
 
         # For each file add a a system placement
-        for abs_file in ${abs_files[@]}
+        for abs_file in "${abs_files[@]}"
         do
             parent_dir=$(dirname $abs_file)
             filename=$(basename $abs_file)
@@ -241,7 +241,7 @@ generate_manpage_manifest(){
     # Remove any existing manifest
     rm -f ${DEBIAN_DIR}/${PACKAGE_NAME}.manpages
 
-    for manpage in ${generated_manpages[@]}
+    for manpage in "${generated_manpages[@]}"
     do
         echo "${docs_rel_path}/${manpage}" >> "${DEBIAN_DIR}/${PACKAGE_NAME}.manpages"
     done
@@ -252,7 +252,7 @@ generate_sample_manifest(){
         generated_manpages=( $(_get_files_in_dir_tree $INPUT_SAMPLES_DIR) )
 
         rm -f sample_manifest
-        for sample in ${samples[@]}
+        for sample in "${samples[@]}"
         do
             echo "$sample" >> "${DEBIAN_DIR}/${PACKAGE_NAME}.examples"
         done

src/Microsoft.DotNet.Build.Tasks.Installers/build/deb-package-tool/scripts/debian_build_lib.sh

@@ -51,7 +51,7 @@ add_system_dir_placement(){
         in_package_dir="${in_package_dir}/"
     fi
 
-    for rel_filepath in ${dir_files[@]}
+    for rel_filepath in "${dir_files[@]}"
     do
         local parent_path=$(dirname $rel_filepath)
 
@@ -122,7 +122,7 @@ _copy_files_to_package(){
     shift; shift;
     rel_filepath_list=( $@ )
 
-    for rel_filepath in ${rel_filepath_list[@]}
+    for rel_filepath in "${rel_filepath_list[@]}"
     do
         local parent_dir=$(dirname $rel_filepath)
         local filename=$(basename $rel_filepath)

test.sh

@@ -13,4 +13,4 @@ while [[ -h $source ]]; do
 done
 
 scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
-"$scriptroot/eng/common/build.sh" --test $@
+"$scriptroot/eng/common/build.sh" --test "$@"