Remove unnnecessary null suppressions in Roslyn.sln

Author: CyrusNajmabadi

src/Analyzers/CSharp/Analyzers/UseExpressionBody/Helpers/UseExpressionBodyHelper`1.cs

@@ -186,7 +186,7 @@ public bool CanOfferUseBlockBody(
         var languageVersion = declaration.GetLanguageVersion();
         if (languageVersion < LanguageVersion.CSharp7)
         {
-            if (expressionBody!.Expression.IsKind(SyntaxKind.ThrowExpression))
+            if (expressionBody.Expression.IsKind(SyntaxKind.ThrowExpression))
             {
                 // If they're using a throw expression in a declaration and it's prior to C# 7
                 // then always mark this as something that can be fixed by the analyzer.  This way

src/Analyzers/Core/Analyzers/MatchFolderAndNamespace/AbstractMatchFolderAndNamespaceDiagnosticAnalyzer.cs

@@ -147,7 +147,7 @@ private bool IsFileAndNamespaceMismatch(
 
         var relativeDirectoryPath = PathUtilities.GetRelativePath(
             projectDir,
-            PathUtilities.GetDirectoryName(namespaceDeclaration.SyntaxTree.FilePath)!);
+            PathUtilities.GetDirectoryName(namespaceDeclaration.SyntaxTree.FilePath));
         var folders = relativeDirectoryPath.Split([Path.DirectorySeparatorChar], StringSplitOptions.RemoveEmptyEntries);
 
         var expectedNamespace = PathMetadataUtilities.TryBuildNamespaceFromFolders(folders, GetSyntaxFacts(), rootNamespace);

src/Analyzers/Core/Analyzers/RemoveUnnecessarySuppressions/AbstractRemoveUnnecessaryAttributeSuppressionsDiagnosticAnalyzer.cs

@@ -109,7 +109,7 @@ public void AnalyzeAssemblyOrModuleAttribute(SyntaxNode attributeSyntax, Semanti
                     }
                 }
 
-                reportDiagnostic(Diagnostic.Create(LegacyFormatTargetDescriptor, targetValueOperation.Syntax.GetLocation(), properties!, targetSymbolString));
+                reportDiagnostic(Diagnostic.Create(LegacyFormatTargetDescriptor, targetValueOperation.Syntax.GetLocation(), properties, targetSymbolString));
                 return;
             }
         }

src/Analyzers/Core/Analyzers/UseCollectionInitializer/AbstractObjectCreationExpressionAnalyzer.cs

@@ -95,7 +95,7 @@ protected UpdateExpressionState<TExpressionSyntax, TStatementSyntax> TryInitiali
         TObjectCreationExpressionSyntax rootExpression,
         CancellationToken cancellationToken)
     {
-        var statement = rootExpression.FirstAncestorOrSelf<TStatementSyntax>()!;
+        var statement = rootExpression.FirstAncestorOrSelf<TStatementSyntax>();
         if (statement != null)
         {
             var result =

src/Analyzers/Core/Analyzers/UseCollectionInitializer/UpdateExpressionState.cs

@@ -47,7 +47,7 @@ internal readonly struct UpdateExpressionState<
     /// <summary>
     /// The statement containing <see cref="StartExpression"/>
     /// </summary>
-    public readonly TStatementSyntax? ContainingStatement = startExpression.FirstAncestorOrSelf<TStatementSyntax>()!;
+    public readonly TStatementSyntax? ContainingStatement = startExpression.FirstAncestorOrSelf<TStatementSyntax>();
 
     /// <summary>
     /// The name of the value being mutated.  It is whatever the new object-creation or collection-builder is assigned to.

src/Analyzers/Core/Analyzers/ValidateFormatString/AbstractValidateFormatStringDiagnosticAnalyzer.cs

@@ -200,7 +200,7 @@ private bool ArgsIsArrayOfReferenceTypes(
         }
 
         Debug.Assert(syntaxFacts.IsArgument(argsArgument));
-        var expression = syntaxFacts.GetExpressionOfArgument(argsArgument)!;
+        var expression = syntaxFacts.GetExpressionOfArgument(argsArgument);
         return semanticModel.GetTypeInfo(expression).ConvertedType;
     }
 

src/Analyzers/Core/CodeFixes/ImplementInterface/ImplementInterfaceGenerator_Property.cs

@@ -81,7 +81,7 @@ private ImmutableArray<ISymbol> GeneratePropertyMembers(
         private static INamedTypeSymbol[] AttributesToRemove(Compilation compilation)
         {
             return new[] { compilation.ComAliasNameAttributeType(), compilation.TupleElementNamesAttributeType(),
-                compilation.DynamicAttributeType(), compilation.NativeIntegerAttributeType() }.WhereNotNull().ToArray()!;
+                compilation.DynamicAttributeType(), compilation.NativeIntegerAttributeType() }.WhereNotNull().ToArray();
         }
 
         private IMethodSymbol? GenerateSetAccessor(

src/Analyzers/Core/CodeFixes/UseSystemHashCode/UseSystemHashCodeCodeFixProvider.cs

@@ -70,7 +70,7 @@ protected override async Task FixAllAsync(
 
                 // Only if there was a base.GetHashCode() do we pass in the ContainingType
                 // so that we generate the same.
-                var containingType = accessesBase ? method!.ContainingType : null;
+                var containingType = accessesBase ? method.ContainingType : null;
                 var components = generator.GetGetHashCodeComponents(
                     generatorInternal, semanticModel.Compilation, containingType, members, justMemberReference: true);
 

src/Compilers/CSharp/Portable/Binder/Binder_Conversions.cs

@@ -2464,7 +2464,7 @@ private BoundExpression CreateTupleLiteralConversion(SyntaxNode syntax, BoundTup
                         locationBuilder.Add(argument.NameColon?.Name.Location);
                     }
 
-                    targetType = targetType.WithElementNames(sourceTuple.ArgumentNamesOpt!,
+                    targetType = targetType.WithElementNames(sourceTuple.ArgumentNamesOpt,
                         locationBuilder.ToImmutableAndFree(),
                         errorPositions: default,
                         ImmutableArray.Create(tupleSyntax.Location));

src/Compilers/CSharp/Portable/Binder/Binder_Deconstruct.cs

@@ -717,7 +717,7 @@ private BoundBadExpression MissingDeconstruct(BoundExpression receiver, SyntaxNo
         {
             if (receiver.Type?.IsErrorType() == false)
             {
-                Error(diagnostics, ErrorCode.ERR_MissingDeconstruct, rightSyntax, receiver.Type!, numParameters);
+                Error(diagnostics, ErrorCode.ERR_MissingDeconstruct, rightSyntax, receiver.Type, numParameters);
             }
 
             outPlaceholders = default;