Completion builder prefers regular completions over built ones and activates them in lambda parameters

[Peter-Juhasz]

VS 17.11.0 P2.1

Completion session controller should select the built completion when naming variables (in this case lambda expression parameter name), instead of matching the existing symbols or regular completions provided.

This makes writing lambda expressions quite frustrating, because every time it completes the name I try to assign to a completion from the list.

Rogzites.2024-07-06.225221.mp4

@code {
    protected override void OnInitialized()
    {
        int[] numbers = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10];
        var even = numbers.Where(n$$);
        base.OnInitialized();
    }
}

[ryzngard]

Interestingly it seems to also happen in csharp files

@alexgav is this something we should move over to dotnet/roslyn?

[alexgav]

I believe the main difficulty @Peter-Juhasz is having is not so much that the "standard" completion items are present in the completion list, but the fact that they are selected via "hard" (as opposed to "soft" :) ) selection in LSP. That causes them to be completed when space is typed. As @ryzngard said it reproes in plain C# files if I enabled LSP C#/VB editor (which is what Razor uses). In "old" C# editor (default for standalone C# files) actually uses soft selection in this case and won't commit selected item. E.g. if you type "n" in Razor and LSP C#, you get "nameof" completed, even if you actually want to do something like "n => n > 3".

In the old (current C#) editor, even though nameof gets soft selected, it is not completed when space is pressed, so instead of ending up with Where(nameof ) you actually get Where(n )

I agree though, this should go to Roslyn. @ToddGrun and @genlu .

[CyrusNajmabadi]

Moving to razor as this seems to be rzor specific. In C# we do the right thing and soft select these items. WHich is very intentional as you might be writing a new name, or passing an existing value. IN that scenario, only tab should commit the item. If this is not happening in razor, it is something specific to them.

[dibarbet]

Actually I think this is still on the Roslyn side, probably the VS LSP completion handler. I did notice that it works correctly in vscode. I suspect something on the conversion to VS lsp items is wrong.