Skip to content

add match_subject_alt_names to TLSContext resource #5357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add match_subject_alt_names to TLSContext resource #5357

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa80bef
add match_subject_alt_names to TLSContext resource
aburan28 Oct 14, 2023
1e7fcea
Update v3tls.py
aburan28 Oct 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion python/ambassador/envoy/v3/v3tls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def update_tls_cipher(self, key: str, value: List[str]) -> None:

params[key] = value

def update_validation(self, key: str, value: str) -> None:
def update_validation(self, key: str, value: str, match_typed_subject_alt_names: Optional[List[Dict[str, str]]] = None) -> None:
empty_context: EnvoyValidationContext = {}

# This looks weirder than you might expect, because self.get_common().setdefault() is a truly
Expand All @@ -118,6 +118,8 @@ def update_validation(self, key: str, value: str) -> None:

src: EnvoyCoreSource = {"filename": value}
validation[key] = src
if match_subject_alt_names is not None:
validation['match_typed_subject_alt_names'] = match_subject_alt_names

def add_context(self, ctx: IRTLSContext) -> None:
if TYPE_CHECKING:
Expand All @@ -142,6 +144,8 @@ def add_context(self, ctx: IRTLSContext) -> None:
("min_tls_version", self.update_tls_version, "tls_minimum_protocol_version"),
("max_tls_version", self.update_tls_version, "tls_maximum_protocol_version"),
("sni", self.__setitem__, "sni"),
("match_subject_alt_names", self.update_validation, "match_subject_alt_names"),

]:
value = ctx.get(ctxkey, None)

Expand Down