Skip to content

feat: expose ipFamilies and allow to disable module #5537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev/v4/main
Choose a base branch
from
Open

feat: expose ipFamilies and allow to disable module #5537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/emissary-ingress/templates/module.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.module }}
{{- if .Values.module.enabled -}}
apiVersion: getambassador.io/v3alpha1
kind: Module
metadata:
Expand All @@ -12,7 +12,7 @@ metadata:
spec:
{{- if .Values.env }}
{{- if hasKey .Values.env "AMBASSADOR_ID" }}
ambassador_id:
ambassador_id:
- {{ .Values.env.AMBASSADOR_ID | quote }}
{{- end }}
{{- end }}
Expand Down
4 changes: 4 additions & 0 deletions charts/emissary-ingress/templates/service-canary.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,5 +73,9 @@ spec:
externalIPs:
{{- toYaml .Values.service.externalIPs | nindent 4 }}
{{- end }}
{{- if .Values.service.ipFamilies }}
ipFamilies:
{{- toYaml .Values.service.ipFamilies | nindent 4 }}
{{- end }}
{{- end }}
{{- end }}
6 changes: 5 additions & 1 deletion charts/emissary-ingress/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,8 @@ spec:
{{- if .Values.service.externalIPs }}
externalIPs:
{{- toYaml .Values.service.externalIPs | nindent 4 }}
{{- end }}
{{- end }}
{{- if .Values.service.ipFamilies }}
ipFamilies:
{{- toYaml .Values.service.ipFamilies | nindent 4 }}
{{- end }}
1 change: 1 addition & 0 deletions charts/emissary-ingress/values.yaml.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,7 @@ resolvers: # +doc-gen:break
# separate ambassador_ids, and set `module: {}` in your Helm values to prevent
# creation of a Module object.
module:
enabled: true
diagnostics:
enabled: false
allow_non_local: true
Expand Down