Skip to content

Commit 7cabf7d

Browse files
Merge pull request #62 from fivetran/MagicBot/package-extract-url-parameters
Extract URL Parameter Macro Update
2 parents fe04117 + 1b04649 commit 7cabf7d

File tree

10 files changed

+36
-13
lines changed

10 files changed

+36
-13
lines changed

.github/workflows/auto-release.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
name: 'auto release'
2+
on:
3+
pull_request:
4+
types:
5+
- closed
6+
branches:
7+
- main
8+
9+
jobs:
10+
call-workflow-passing-data:
11+
if: github.event.pull_request.merged
12+
uses: fivetran/dbt_package_automations/.github/workflows/auto-release.yml@main
13+
secrets: inherit

.gitignore

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
1+
package-lock.yml
22
target/
33
dbt_modules/
44
logs/
5-
5+
env/
66
dbt_packages/

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1+
# dbt_google_ads v0.10.1
2+
[PR #62](https://github.com/fivetran/dbt_google_ads/pull/62) includes the following updates:
3+
4+
## Bug Fixes
5+
- This package now leverages the new `google_ads_extract_url_parameter()` (located within the dbt_google_ads_source package) macro for use in parsing out url parameters. This was added to create special logic for Databricks instances not supported by `dbt_utils.get_url_parameter()`.
6+
- This macro will be replaced with the `fivetran_utils.extract_url_parameter()` macro in the next breaking change of this package.
7+
8+
## Under the Hood
9+
- Included auto-releaser GitHub Actions workflow to automate future releases.
10+
111
# dbt_google_ads v0.10.0
212
[PR #52](https://github.com/fivetran/dbt_google_ads/pull/52) includes the following updates:
313
## Feature update 🎉

dbt_project.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: 'google_ads'
2-
version: '0.10.0'
2+
version: '0.10.1'
33

44
config-version: 2
55
require-dbt-version: [">=1.3.0", "<2.0.0"]

docs/catalog.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

docs/index.html

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

docs/manifest.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

docs/run_results.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

integration_tests/dbt_project.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: 'google_ads_integration_tests'
2-
version: '0.10.0'
2+
version: '0.10.1'
33

44
profile: 'integration_tests'
55
config-version: 2

models/google_ads__url_report.sql

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,10 @@ fields as (
5353

5454
{% if var('google_auto_tagging_enabled', false) %}
5555

56-
coalesce( {{ dbt_utils.get_url_parameter('ads.final_url', 'utm_source') }} , 'google') as utm_source,
57-
coalesce( {{ dbt_utils.get_url_parameter('ads.final_url', 'utm_medium') }} , 'cpc') as utm_medium,
58-
coalesce( {{ dbt_utils.get_url_parameter('ads.final_url', 'utm_campaign') }} , campaigns.campaign_name) as utm_campaign,
59-
coalesce( {{ dbt_utils.get_url_parameter('ads.final_url', 'utm_content') }} , ad_groups.ad_group_name) as utm_content,
56+
coalesce( {{ google_ads_source.google_ads_extract_url_parameter('ads.final_url', 'utm_source') }} , 'google') as utm_source,
57+
coalesce( {{ google_ads_source.google_ads_extract_url_parameter('ads.final_url', 'utm_medium') }} , 'cpc') as utm_medium,
58+
coalesce( {{ google_ads_source.google_ads_extract_url_parameter('ads.final_url', 'utm_campaign') }} , campaigns.campaign_name) as utm_campaign,
59+
coalesce( {{ google_ads_source.google_ads_extract_url_parameter('ads.final_url', 'utm_content') }} , ad_groups.ad_group_name) as utm_content,
6060

6161
{% else %}
6262

0 commit comments

Comments
 (0)