Skip to content

Conversation

@matheuscscp
Copy link
Member

@matheuscscp matheuscscp commented May 4, 2025

Depends on: fluxcd/pkg#919

Part of: fluxcd/flux2#5022

This PR also introduces a token cache for caching the cloud provider access tokens. This token cache will report the following metrics:

  • Counter gotk_token_cache_events_total
    • Help: Total number of cache retrieval events for a Gitops Toolkit resource reconciliation.
    • Labels: event_type, kind, name, namespace, operation. The values of event_type can be cache_miss or cache_hit. The value of operation is always reconcile.
  • Counter gotk_token_cache_requests_total
    • Help: Total number of cache requests partioned by success or failure.
    • Labels: status. The values of status can be success or failure.
  • Counter gotk_token_cache_evictions_total
    • Help: Total number of cache evictions.
    • No labels.
  • Gauge gotk_token_cached_items
    • Help: Total number of items in the cache.
    • No labels.

I tested this PR in the following setups:

AWS:

  • Controller-level
  • Object-level

Azure:

  • Controller-level
  • Object-level

GCP:

  • Controller-level with GCP service account impersonation
  • Object-level with GCP service account impersonation
  • Object-level with direct access

@matheuscscp matheuscscp force-pushed the rfc-0010 branch 3 times, most recently from 816e227 to 5803eed Compare May 5, 2025 19:05
@stefanprodan stefanprodan changed the title [RFC-0010] Introduce object-level workload identity [RFC-0010] Introduce object-level workload identity for ImageRepository May 7, 2025
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @matheuscscp 🏅

@matheuscscp matheuscscp merged commit b3a615c into main May 7, 2025
6 checks passed
@matheuscscp matheuscscp deleted the rfc-0010 branch May 7, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants