Add feature gate to cancel health checks on new revisions #1520
+246
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
added
area/kstatus
matheuscscp
force-pushed
the
cancel-health-checks
branch
from
d79cf2a to
a7d8c89
Compare
matheuscscp
force-pushed
the
cancel-health-checks
branch
from
a7d8c89 to
724ae73
Compare
Signed-off-by: Matheus Pimenta <[email protected]> Co-authored-by: Stephen Solka <[email protected]>
matheuscscp
force-pushed
the
cancel-health-checks
branch
from
724ae73 to
b28d750
Compare
stefanprodan
approved these changes
Sep 25, 2025
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @matheuscscp and @trashhalo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the feature gate
CancelHealthCheckOnNewRevisionfor allowing health checks to be cancelled earlier in case a new revision of the source is observed.Co-authored-by: @trashhalo (xref: #1518)
Includes: fluxcd/pkg#1033