Skip to content

Conversation

@Cito
Copy link
Member

@Cito Cito commented Nov 20, 2024

  • Mention in the docstring of asyncnullcontext that it is only needed for old Python versions (but we need to keep it in as long as we support Python 3.9)
  • Test that asyncnullcontext works exactly like nullcontext for newer Python versions
  • Update dependencies and adapt tests to latest pytest_httpx

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11935378528

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 90.83%

Files with Coverage Reduction New Missed Lines %
.tox/py312/lib/python3.12/site-packages/ghga_service_commons/api/mock_router.py 1 96.58%
Totals Coverage Status
Change from base Build 11723443134: -0.1%
Covered Lines: 733
Relevant Lines: 807

💛 - Coveralls

@Cito Cito requested a review from TheByronHimes November 20, 2024 14:31
@Cito Cito merged commit 98fdf4e into main Dec 5, 2024
5 checks passed
@Cito Cito deleted the feature/add-note-on-asyncnullcontext branch December 5, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants