Skip to content

Conversation

@candemiralp
Copy link
Contributor

Description

The Test Webhook button under the Initial Setup section of the plugin configuration allows merchants to test their webhook configuration leveraging the Management API under the hood. However, this functionality was broken due to incorrect response handling.

This PR fixes the API response handling and returns the correct result to the frontend.

Note that, there is a backward incompatible change on the Management API between versions V1 and V3. Due to this change, plugins configured earlier using the Management API V1 might still show incorrect results. To tackle this, please configure the webhook using Auto Configuration mode again.

Tested scenarios

  • Test Webhook button with auto configuration feature of the module

Fixes #3098

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @candemiralp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where the 'Test Webhook' button within the plugin's initial setup was not functioning correctly. The core problem stemmed from improper processing of the Management API's response. The changes implement robust response handling, ensuring that merchants receive accurate and reliable feedback when testing their webhook configurations. Additionally, it provides important guidance for users who might encounter issues due to a backward-incompatible change in the Management API.

Highlights

  • Webhook Test Button Fix: The 'Test Webhook' button in the plugin configuration, which was previously non-functional due to incorrect API response handling, has been repaired.
  • Improved API Response Handling: The pull request introduces correct handling of the Management API's TestWebhookResponse object, ensuring accurate feedback is returned to the frontend.
  • Backward Compatibility Note: A note has been added regarding a backward incompatible change between Management API V1 and V3, advising users with older configurations to reconfigure their webhooks using Auto Configuration mode.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue with the 'Test Webhook' button by updating how the API response is handled. The change correctly adapts to the new response structure from the Adyen Management API. I've found a potential issue that could lead to a fatal error if the API response contains an empty data array and have provided a suggestion to make the code more robust.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@candemiralp candemiralp merged commit 8a0b031 into main Oct 14, 2025
7 of 12 checks passed
@candemiralp candemiralp deleted the ECP-9827 branch October 14, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Indicates a bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ECP-9827][Bug]: Integration Method - Automatic. - Web hooks validation failed

3 participants