Update locale keys and values to use sentence casing #8182
Conversation
efb4f5ff-1298-471a-8973-3d47447115dc
changed the title
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
efb4f5ff-1298-471a-8973-3d47447115dc
marked this pull request as ready for review
github-actions
bot
added
the
PR: waiting for review
Pull request was converted to draft
github-actions
bot
removed
the
PR: waiting for review
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
Closing and splitting up in smaller easy to review PR's. Also i wont incorporate the key standardization as the changes to sentence casing are user facing and the standardization isnt |
1 participant
Pull Request Type
Related issue
Closes #5000
Description
Updates all keys and values to use sentence casing to have consistent wording thought our application similar to YT. I still need to update the keys in all the other locale files and in the files where the keys are actually being used. Before i continue todo that i require some help, see Additional context section.
Testing
Additional context
Help needed on this matter: @absidue @PikachuEXE @kommunarr @ChunkyProgrammer @MarmadileManteater
This PR is drafted because of what has been described in the Description section and the following.
IMO we have a problem how keys are being used in our files and i would like to address that in this PR (allot of keys are being updated anyway so why not kill two birds with one stone). We have no consistent naming convention on how a key should be written.
Examples taken from the file:
Next chapter:KeyboardShortcutPrompt:shortcutLabelSeparator:This video is unavailable because of missing formats. This can happen due to country unavailability.:Im in favor of using camel case so that its consistent with our codebase and a nice addition is that the keys will become smaller but ofcourse still be descriptive so everyone knows what that key is used for. If we dont want to change this im fine with it because less work for me but i thought that i at least ask about it