Fix comment toggle link text #8210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
Nov 3, 2025
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
Isnt really working as expected. Other replies arent showing up anymore
Before
After
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
Collaborator
Author
|
Fixed, the |
PikachuEXE
added
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Nov 5, 2025
absidue
reviewed
Nov 5, 2025
…late Also add/update type definition for comment objects
Collaborator
Author
|
Now using a function to output link text, so early return can be used |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 6, 2025
absidue
approved these changes
Nov 6, 2025
PikachuEXE
commented
Nov 8, 2025
Comment on lines
+1015
to
+1016
| View 1 reply from {channelName}: View 1 reply from {channelName} | ||
| View {replyCount} replies from {channelName} and others: View {replyCount} replies from {channelName} and others |
Collaborator
Author
There was a problem hiding this comment.
Should I merge these 2 too?
There was a problem hiding this comment.
Sure only if you want but you dont have to imo
Member
|
A bit related. Our About page is also using these exact structures. Is it possible to address that in a followup? |
ChunkyProgrammer
approved these changes
Nov 8, 2025
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
#8094
Description
After vue 3 upgrade the reply link text is broken and this PR fixes it
Also updated "more replies" link text (pluralization
Screenshots
Lazy
Testing
For with owner reply link text see https://youtu.be/_l4ARG1Ti5k
For without owner reply see https://youtu.be/7kkVoKfG0dA
For "more replies" link text - no idea
Desktop
Additional context
The existing one is a rather old implementation (from 5 years ago with fixes in more recent years) https://github.com/FreeTubeApp/FreeTube/blame/96f60d8d998e282d670a48a90a3ad1a61cba226e/src/renderer/components/watch-video-comments/watch-video-comments.vue