Skip to content

Conversation

@Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Nov 5, 2025

Description

  1. Adding e2e tests for unsupported paths scenario for different operations like list, copy, rename and delete.
  2. Setting includeFolderAsPrefix flag as while making a list call, the includeFolderAsPrefix parameter must be set to true. This is because the HNS/Rapid bucket only displays folders as part of the CollapsedRuns output when this flag is enabled.

Link to the issue in case of a bug fix.

b/455706503

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - Automated

Any backward incompatible change? If so, please explain.

@Tulsishah Tulsishah added execute-integration-tests Run only integration tests execute-integration-tests-on-zb To run E2E tests on zonal bucket. labels Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.09%. Comparing base (0f5c69c) to head (f625619).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3978      +/-   ##
==========================================
- Coverage   83.13%   83.09%   -0.04%     
==========================================
  Files         148      148              
  Lines       18188    18188              
==========================================
- Hits        15120    15113       -7     
- Misses       2518     2523       +5     
- Partials      550      552       +2     
Flag Coverage Δ
unittests 83.09% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tulsishah Tulsishah changed the title feat(Unsupported Directory fix): E2e test for unsupported directory listing feat(Unsupported Directory fix): E2e test for unsupported directory Nov 5, 2025
@Tulsishah Tulsishah force-pushed the list_e2e_tests_unsupported_dir branch from 57f987d to 39fda34 Compare November 6, 2025 06:42
@Tulsishah Tulsishah changed the title feat(Unsupported Directory fix): E2e test for unsupported directory feat(Unsupported Directory fix): E2e test for unsupported Paths Nov 6, 2025
@Tulsishah Tulsishah changed the title feat(Unsupported Directory fix): E2e test for unsupported Paths feat(Unsupported Directory fix): E2e tests for unsupported Paths Nov 6, 2025
@Tulsishah Tulsishah force-pushed the list_e2e_tests_unsupported_dir branch 9 times, most recently from bb16b24 to 7fceaad Compare November 7, 2025 08:23
@Tulsishah
Copy link
Collaborator Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces end-to-end tests for handling unsupported paths in GCS, covering list, copy, rename, and delete operations. It also includes a necessary fix in deletePrefixRecursively to correctly handle HNS buckets by setting the includeFolderAsPrefixes flag. The new tests are well-structured and provide good coverage for the intended scenarios. My review includes one suggestion to improve the readability and maintainability of the test setup configuration.

@Tulsishah Tulsishah force-pushed the list_e2e_tests_unsupported_dir branch 2 times, most recently from 4bd13b2 to 1ce2638 Compare November 7, 2025 09:58
@Tulsishah Tulsishah force-pushed the list_e2e_tests_unsupported_dir branch from 30239d2 to f625619 Compare November 7, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-integration-tests Run only integration tests execute-integration-tests-on-zb To run E2E tests on zonal bucket.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants