-
Notifications
You must be signed in to change notification settings - Fork 470
feat(Unsupported Directory fix): E2e tests for unsupported Paths #3978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3978 +/- ##
==========================================
- Coverage 83.13% 83.09% -0.04%
==========================================
Files 148 148
Lines 18188 18188
==========================================
- Hits 15120 15113 -7
- Misses 2518 2523 +5
- Partials 550 552 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
57f987d to
39fda34
Compare
bb16b24 to
7fceaad
Compare
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces end-to-end tests for handling unsupported paths in GCS, covering list, copy, rename, and delete operations. It also includes a necessary fix in deletePrefixRecursively to correctly handle HNS buckets by setting the includeFolderAsPrefixes flag. The new tests are well-structured and provide good coverage for the intended scenarios. My review includes one suggestion to improve the readability and maintainability of the test setup configuration.
4bd13b2 to
1ce2638
Compare
30239d2 to
f625619
Compare
Description
Link to the issue in case of a bug fix.
b/455706503
Testing details
Any backward incompatible change? If so, please explain.