Skip to content

Conversation

@rpardini
Copy link
Member

nanopct6(-lts): bump u-boot to v2025.10 final

  • nanopct6(-lts): u-boot: bump 2025.04 -> 2025.10-rc4
  • nanopct6(-lts): bump u-boot to v2025.10 final

@github-actions github-actions bot added size/small PR with less then 50 lines 11 Milestone: Fourth quarter release Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Oct 22, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 22, 2025

Warning

Walkthrough skipped

File diffs could not be summarized.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 189bcaf and bfd69cf.

📒 Files selected for processing (1)
  • config/boards/nanopct6.conf (2 hunks)
🔥 Files not summarized due to errors (1)
  • config/boards/nanopct6.conf: Error: Server error: no LLM provider could handle the message
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: rpardini
PR: armbian/build#8044
File: patch/u-boot/v2025.04/cmd-fileenv-read-string-from-file-into-env.patch:73-75
Timestamp: 2025-03-31T22:20:41.849Z
Learning: When porting patches between U-Boot versions (like from 2025.01 to 2025.04), rpardini prefers to maintain patches as-is rather than introducing refactoring changes, even when potential improvements are identified. This approach prioritizes consistency and reduces the risk of introducing new issues.
📚 Learning: 2025-10-14T05:08:11.785Z
Learnt from: EvilOlaf
PR: armbian/build#8754
File: config/boards/bestv-r3300-l.csc:14-16
Timestamp: 2025-10-14T05:08:11.785Z
Learning: In the Armbian build system, BOOTBRANCH_BOARD is a valid framework variable used as a fallback when BOOTBRANCH is unset. The framework checks BOOTBRANCH_BOARD before applying the default bootloader branch value (see config/sources/common.conf). Board configuration files can use BOOTBRANCH_BOARD to specify the bootloader branch.

Applied to files:

  • config/boards/nanopct6.conf
📚 Learning: 2025-07-23T07:30:52.265Z
Learnt from: EvilOlaf
PR: armbian/build#8417
File: config/boards/orangepi5pro.csc:57-58
Timestamp: 2025-07-23T07:30:52.265Z
Learning: In the Armbian build system, BOOTPATCHDIR can contain board-specific subdirectories (e.g., board_orangepi5pro) for applying patches to specific boards only. The framework automatically checks if such board-specific subdirectories exist for the board being built and applies those patches accordingly.

Applied to files:

  • config/boards/nanopct6.conf
📚 Learning: 2025-09-14T06:32:29.806Z
Learnt from: amazingfate
PR: armbian/build#8619
File: config/sources/families/rockchip.conf:222-230
Timestamp: 2025-09-14T06:32:29.806Z
Learning: In the Armbian build system, the write_uboot_platform() function implementations follow different patterns across Rockchip family files. The newer standard (used in rockchip64_common.inc and rk3506) includes 'status=none' parameter in dd commands, while older implementations (rk3288, rk322x) use an older pattern without this parameter. The rk3506 implementation correctly follows the current Rockchip family standard.

Applied to files:

  • config/boards/nanopct6.conf
🔇 Additional comments (2)
config/boards/nanopct6.conf (2)

45-46: Verify that u-boot patches have been migrated to v2025.10 directory.

The BOOTPATCHDIR references v2025.10, which must correspond to a patch directory at patch/u-boot/v2025.10/. Additionally, the PR mentions a two-stage version bump (2025.04 → 2025.10-rc4 → v2025.10 final), but this config shows only the final v2025.10 tag. Ensure that:

  1. The patch directory exists and contains necessary board-specific patches for v2025.10
  2. Any patches from v2025.04 have been appropriately migrated or are no longer needed
  3. The nanopct6-lts.conf board file has matching version updates

73-79: Verify the u-boot dtsi append logic handles idempotency correctly.

The function switches from a patch-based approach to dynamically appending USB gadget/OTG configuration directly to the dtsi file. While this avoids patch maintenance, verify that:

  1. The append is idempotent (won't create duplicates if the function runs multiple times or if a prior build was incomplete)
  2. The dtsi file structure is consistent across u-boot v2025.10 builds
  3. There's no risk of appending to a stale or partially-written file

Consider adding a guard (e.g., checking if content already exists) to prevent accidental duplication.

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rpardini rpardini marked this pull request as ready for review October 22, 2025 17:07
@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Oct 22, 2025
@github-actions
Copy link
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Oct 22, 2025
@igorpecovnik igorpecovnik merged commit 389ac2c into armbian:main Oct 22, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

3 participants