Skip to content

Commit b28fc31

Browse files
authored
#81118: Fix dropdown in "Move static members" dialog (#81119)
Fixes #81118. Apparently the dialog broke when the `TypeNameItem` type was moved to another namespace. This fixes that reference and fixes up some of the bindings that are used in the dialog (and also sets `Mode=OneTime` since the bound properties are readonly and so the model does not change while the dialog is open). <img width="486" height="491" alt="grafik" src="https://github.com/user-attachments/assets/c7de8b8a-3a4b-43cf-aa27-93541f84e35f" />
1 parent f2df0ad commit b28fc31

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/VisualStudio/Core/Def/MoveStaticMembers/MoveStaticMembersDialog.xaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
</Style>
6464
</ComboBox.ItemContainerStyle>
6565
<ComboBox.ItemTemplate>
66-
<DataTemplate DataType="Microsoft.VisualStudio.LanguageServices.Implementation.MoveMembersToType.TypeNameItem">
66+
<DataTemplate DataType="movestaticmembers:TypeNameItem">
6767
<Grid>
6868
<Grid.ColumnDefinitions>
6969
<ColumnDefinition Width="Auto"/>
@@ -73,18 +73,18 @@
7373
</Grid.ColumnDefinitions>
7474
<imaging:CrispImage
7575
Grid.Column="0"
76-
Visibility="{Binding IsFromHistory, Converter={StaticResource BooleanToVisibilityConverter}}"
76+
Visibility="{Binding Path=IsFromHistory, Mode=OneTime, Converter={StaticResource BooleanToVisibilityConverter}}"
7777
Margin="0 0 5 0"
7878
Moniker="{x:Static imagecatalog:KnownMonikers.History}" />
7979
<TextBlock
8080
Grid.Column="3"
8181
HorizontalAlignment="Left"
8282
TextTrimming="CharacterEllipsis"
83-
Text="{Binding TypeName}"/>
83+
Text="{Binding Path=FullyQualifiedTypeName, Mode=OneTime}"/>
8484
<TextBlock
8585
Grid.Column="4"
8686
HorizontalAlignment="Right"
87-
Text="{Binding DeclarationFile}"/>
87+
Text="{Binding Path=DeclarationFileName, Mode=OneTime}"/>
8888
</Grid>
8989
</DataTemplate>
9090
</ComboBox.ItemTemplate>

0 commit comments

Comments
 (0)