Skip to content

Conversation

@pie-r
Copy link
Contributor

@pie-r pie-r commented Jan 30, 2024

Description

Add the possibility to:

  • disable the default module
  • in the service, provide a list of ipFamilies.

The above items, are required to install two emissary in the same namespace, to support both ipv4 and ipv6 at the same time, until #4012 is fixed.

Related Issues

#5536

Testing

It has been tested in aks using it as local chart.

Checklist

  • Does my change need to be backported to a previous release?

    • What backport versions were discussed with the Maintainers in the Issue?
  • I made sure to update CHANGELOG.md.

    Remember, the CHANGELOG needs to mention:

    • Any new features
    • Any changes to our included version of Envoy
    • Any non-backward-compatible changes
    • Any deprecations
  • This is unlikely to impact how Ambassador performs at scale.

    Remember, things that might have an impact at scale include:

    • Any significant changes in memory use that might require adjusting the memory limits
    • Any significant changes in CPU use that might require adjusting the CPU limits
    • Anything that might change how many replicas users should use
    • Changes that impact data-plane latency/scalability
  • My change is adequately tested.

    Remember when considering testing:

    • Your change needs to be specifically covered by tests.
      • Tests need to cover all the states where your change is relevant: for example, if you add a behavior that can be enabled or disabled, you'll need tests that cover the enabled case and tests that cover the disabled case. It's not sufficient just to test with the behavior enabled.
    • You also need to make sure that the entire area being changed has adequate test coverage.
      • If existing tests don't actually cover the entire area being changed, add tests.
      • This applies even for aspects of the area that you're not changing – check the test coverage, and improve it if needed!
    • We should lean on the bulk of code being covered by unit tests, but...
    • ... an end-to-end test should cover the integration points
  • I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.

  • The changes in this PR have been reviewed for security concerns and adherence to security best practices.

@pie-r
Copy link
Contributor Author

pie-r commented Jan 30, 2024

Any chance to have this reviewed?

@tenshinhigashi @LanceEa @kflynn

@ppeble
Copy link
Member

ppeble commented Aug 29, 2025

Hello! Thank you for submitting this. I know that this is very (almost comically) late.

This looks great. Would you mind pointing your PR at the branch dev/v4? We are gearing up to release the next major version and we are trying to get changes into the new branch so we don't have to port it later from main.

Thank you! Once that is done I'll approve and merge.

@pie-r pie-r changed the base branch from master to dev/v4 September 1, 2025 09:40
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 1, 2025
@pie-r
Copy link
Contributor Author

pie-r commented Sep 1, 2025

@ppeble done, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants