-
Notifications
You must be signed in to change notification settings - Fork 10.2k
fix: use testify instead of t.Fatal or t.Error in server package (part 1) #18971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 22 files with indirect coverage changes @@ Coverage Diff @@
## main #18971 +/- ##
=======================================
Coverage 68.83% 68.83%
=======================================
Files 420 420
Lines 35641 35641
=======================================
Hits 24532 24532
- Misses 9687 9691 +4
+ Partials 1422 1418 -4 Continue to review full report in Codecov by Sentry.
|
|
/ok-to-test |
|
/test pull-etcd-verify |
Signed-off-by: Matthieu MOREL <[email protected]>
fuweid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, mmorel-35 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This uses testify instead of testing for t.Fatal or t.Error calls in server package
Related to #18972