www/node24: fix zlib crashes on 32 bit #444
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes crashes of nodejs on 32 bit due to incorrect V8 API usage leading to GC inside GC situations. Bug originally reported in termux/termux-packages#25455 Fix sent upstream in nodejs/node#59623 Full report of the crash https://hackerone.com/reports/3302484
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes crashes of nodejs on 32 bit due to incorrect V8 API usage leading to GC inside GC situations on Linux.
I was able to reproduce crash is reproducible on FreeBSD i686 VM, but I haven't tested this fix on the VM as I have limited experience working with FreeBSD. I would appreciate if you guys could test this and ensure that this is fixing the crash proplerly
Bug originally reported in termux/termux-packages#25455
Fix sent upstream in nodejs/node#59623
Full report of the crash https://hackerone.com/reports/3302484