Partition RNS limbs (not poly coefficients) in key_switch_inner lowering #2208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j2kun
commented
Sep 11, 2025
| module attributes { | ||
| ckks.schemeParam = #ckks.scheme_param< | ||
| logN = 14, | ||
| Q = [36028797019389953, 35184372121601, 35184372744193, 35184373006337, 35184373989377, 35184374874113], |
Collaborator
Author
There was a problem hiding this comment.
I should update these primes to match the rns_full defined above.
AlexanderViand
approved these changes
Sep 17, 2025
Collaborator
AlexanderViand
left a comment
AlexanderViand
left a comment
There was a problem hiding this comment.
Sorry for the late review!
lib/Dialect/Polynomial/Conversions/PolynomialToModArith/PolynomialToModArith.td
Show resolved
Hide resolved
This commit adds a build-materializations option to polynomial-to-mod-arith, which will be deleted after the keyswitch lowering is done. This allows us to properly run lit tests of the partial lowering implementation.
j2kun
force-pushed
the
fix-keyswitch-inner
branch
from
4b492c6 to
2b8bfdb
Compare
j2kun
added
the
pull_ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rns.extract_sliceop as a helper to partition RNS limbs, including a type inference hook