Skip to content

Commit 395d7a7

Browse files
authored
Merge pull request #117 from gsainfoteam/yhkim13/pgb-73
yhkim13/pgb-73 to develop
2 parents 649a96e + 6a0f1e2 commit 395d7a7

File tree

3 files changed

+14
-7
lines changed

3 files changed

+14
-7
lines changed

src/database/repository/user.repository.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Injectable } from "@nestjs/common";
22
import { DatabaseService } from "@src/database/database.service";
33
import { users } from "../../../drizzle/schema/users";
4-
import { eq, inArray } from "drizzle-orm";
4+
import { and, eq, inArray } from "drizzle-orm";
55
import { UserEntity } from "@src/database/entity/user.entity";
66
import { userAlarmSetting } from "../../../drizzle/schema/user-alarm-setting";
77
import { bank } from "../../../drizzle/schema/bank";
@@ -15,13 +15,13 @@ export class UserRepository {
1515
constructor(private readonly dbService: DatabaseService) {}
1616

1717
/*
18-
SELECT * FROM user WHERE pk = ?1;
18+
SELECT * FROM user WHERE pk = ?1 and is_deleted = false;
1919
*/
2020
async findUserByPk(pk: string): Promise<UserEntity | null> {
2121
const result = await this.dbService.db
2222
.select()
2323
.from(users)
24-
.where(eq(users.pk, pk));
24+
.where(and(eq(users.pk, pk), eq(users.isDeleted, false)));
2525

2626
if (result.length === 0) {
2727
return null;
@@ -41,13 +41,13 @@ export class UserRepository {
4141
}
4242

4343
/*
44-
SELECT * FROM user WHERE idp_sub = ?1;
44+
SELECT * FROM user WHERE idp_sub = ?1 and is_deleted = false;
4545
*/
4646
async findUserByIdpSub(idpSub: string): Promise<UserEntity | null> {
4747
const result = await this.dbService.db
4848
.select()
4949
.from(users)
50-
.where(eq(users.idpSub, idpSub));
50+
.where(and(eq(users.idpSub, idpSub), eq(users.isDeleted, false)));
5151

5252
if (result.length === 0) {
5353
return null;
@@ -77,7 +77,7 @@ export class UserRepository {
7777
INNER JOIN user_alarm_setting as uas ON uas.device_fk = ?2
7878
LEFT OUTER JOIN user_bank as ub ON ub.user_fk = u.pk
7979
LEFT JOIN bank as b ON b.pk = ub.bank_fk
80-
WHERE pk = ?1;
80+
WHERE pk = ?1 and u.is_deleted = false;
8181
*/
8282
async getUserInfoByPk(userId: string, deviceId: string) {
8383
const result = await this.dbService.db
@@ -95,7 +95,7 @@ export class UserRepository {
9595
.innerJoin(userAlarmSetting, eq(userAlarmSetting.deviceFk, deviceId))
9696
.leftJoin(userBank, eq(userBank.userFk, users.pk))
9797
.leftJoin(bank, eq(bank.pk, userBank.bankFk))
98-
.where(eq(users.pk, userId));
98+
.where(and(eq(users.pk, userId), eq(users.isDeleted, false)));
9999

100100
if (result.length === 0) {
101101
return null;
@@ -157,6 +157,7 @@ export class UserRepository {
157157
}
158158

159159
/*
160+
아래 쿼리는 is_deleted=true 인 유저에 대해서도 쿼리가 진행되어야 합니다.
160161
SELECT u.pk, u.name
161162
FROM user as u
162163
WHERE u.pk in (?1);
@@ -177,6 +178,7 @@ export class UserRepository {
177178
}
178179

179180
/*
181+
아래 쿼리는 is_deleted=true 인 유저가 쿼리하지 못합니다.
180182
SELECT u.pk, u.name
181183
FROM user as u
182184
WHERE u.pk = ?1;

src/global/filters/all-exception.filter.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ export class AllExceptionsFilter implements ExceptionFilter {
2929
// 다만 UnauthorizedException 은 HttpExceptionFilter에서 처리되지 않으므로 여기서 로깅 없이 처리
3030
if (exception instanceof UnauthorizedException) {
3131
const status = exception.getStatus();
32+
this.logger.error(
33+
`[Response] Status: ${status}, Message: ${exception.message}`,
34+
);
3235
response.status(status).json({
3336
statusCode: status,
3437
message: exception.message,

src/websocket/websocket.service.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,8 @@ export class WebsocketService implements OnModuleDestroy {
104104
throw new WsException("Invalid refresh token"); // TODO
105105
}
106106

107+
// TODO: 탈퇴한 회원 검사
108+
107109
// 인증 처리
108110
client.setAuthorized(userId, devicePk, accessToken, validUntil);
109111
client.sendMessage(okRes);

0 commit comments

Comments
 (0)