Skip to content

Conversation

@ptang-nr
Copy link
Contributor

@ptang-nr ptang-nr commented Nov 6, 2025

Add preliminary validation for MFE target id and name values.

Overview

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-464423

Testing

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Supportability Metric Usage Changes:

No matching changes found

Supportability Metrics .md File Changes:

supportability_metrics.md was changed? false

New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 25.96 kB / 9.8 kB (gzip) 25.96 kB / 9.8 kB (gzip) 0% / 0% (gzip)
lite async-chunk 53.84 kB / 18.05 kB (gzip) 53.84 kB / 18.05 kB (gzip) 0% / 0% (gzip)
pro loader 54.47 kB / 19.25 kB (gzip) 54.62 kB / 19.29 kB (gzip) 0.29% / 0.22% (gzip)
pro async-chunk 92.57 kB / 29.01 kB (gzip) 92.57 kB / 29.01 kB (gzip) 0% / 0.01% (gzip)
spa loader 63.32 kB / 21.95 kB (gzip) 63.48 kB / 21.99 kB (gzip) 0.25% / 0.19% (gzip)
spa async-chunk 117.98 kB / 36.32 kB (gzip) 117.98 kB / 36.33 kB (gzip) 0% / 0.01% (gzip)

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.47%. Comparing base (f648e3f) to head (ada74ff).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1625   +/-   ##
=======================================
  Coverage   88.47%   88.47%           
=======================================
  Files         206      206           
  Lines        7763     7767    +4     
  Branches     1593     1595    +2     
=======================================
+ Hits         6868     6872    +4     
  Misses        782      782           
  Partials      113      113           
Flag Coverage Δ
unit-tests 81.73% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ptang-nr ptang-nr marked this pull request as ready for review November 6, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants