Remove createPort methods #284
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SmrPort::createPort` is equivalent to `getPort`, so just remove it. We can also remove the wrapper with the same name from `SmrSector`.
Page-
approved these changes
Jan 17, 2018
Member
Page-
left a comment
Page-
left a comment
There was a problem hiding this comment.
I agree it's a redundant method, although it is a shame to lose the hint that we're intending to create a port vs intending to get an existing one
Member
Author
|
Yeah, I was thinking the alternative would be to have a real |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SmrPort::createPortis equivalent togetPort, so justremove it. We can also remove the wrapper with the same name
from
SmrSector.