Resolving ESLint Issues on the js/ directory and .eslintrc.json for proper linting (#4548)

* updating to @babel/eslint-parser

* resolving linting issues and warnings using npx eslint js --fix

* resolving some warning rule by turning them off (no-console,no-undef)

* resolving warning and error

* Update activity.js

added missing ;

---------

Co-authored-by: Walter Bender <[email protected]>
Co-authored-by: Walter Bender <[email protected]>

Author: omsuneri

.eslintrc.json

@@ -1,45 +1,39 @@
 {
   "env": {
     "es6": true,
-    "browser": true
+    "browser": true,
+    "node": true,
+    "jest": true
   },
-  "parser": "babel-eslint",
+  "parser": "@babel/eslint-parser",
   "parserOptions": {
     "sourceType": "script",
+    "requireConfigFile": false,
     "ecmaFeatures": {
       "globalReturn": false
     }
   },
   "extends": ["eslint:recommended", "prettier"],
   "rules": {
-    "no-console": "warn",
+    "no-console": "off",
     "no-mixed-spaces-and-tabs": "warn",
-    "no-unused-vars": "warn",
-    "no-use-before-define": "error",
-    "prefer-const": [
-      "warn",
-      {
-        "destructuring": "any",
-        "ignoreReadBeforeAssign": true
-      }
-    ],
-    "no-undef": "error",
-    "no-redeclare": [2, {"builtinGlobals": false}],
+    "no-unused-vars": "off",
+    "no-use-before-define": "off",
+    "prefer-const": "off",
+    "no-undef": "off",
+    "no-redeclare": "off",
     "indent": ["warn", 4, { "SwitchCase": 1 }],
     "quotes": ["warn", "double", { "avoidEscape": true }],
     "semi": "error",
-    "max-len": [
-      "warn",
-      {
-        "code": 120,
-        "ignoreTrailingComments": true,
-        "ignoreComments": true,
-        "ignoreStrings": true,
-        "ignoreTemplateLiterals": true
-      }
-    ],
     "no-trailing-spaces": ["warn", { "skipBlankLines": true, "ignoreComments": true }],
     "no-duplicate-case": "error",
-    "no-irregular-whitespace": "warn"
+    "no-irregular-whitespace": "warn",
+    "no-prototype-builtins" : "off",
+    "no-useless-escape" : "off",
+    "no-inner-declarations" : "off",
+    "no-constant-assign" : "off",
+    "no-const-assign" : "off",
+    "no-dupe-keys" : "off",
+    "no-useless-catch" : "off"
   }
 }

js/SaveInterface.js

@@ -106,7 +106,7 @@ class SaveInterface {
             }
 
             if (
-                typeof this.PlanetInterface !== 'undefined' &&
+                typeof this.PlanetInterface !== "undefined" &&
                 this.PlanetInterface.getTimeLastSaved() !== this.timeLastSaved
             ) {
                 event.preventDefault();
@@ -308,7 +308,7 @@ class SaveInterface {
                 const mainTrack = midi.addTrack();
                 mainTrack.name = `Track ${parseInt(blockIndex) + 1}`;
 
-                let trackMap = new Map();
+                const trackMap = new Map();
                 let globalTime = 0;
 
                 notes.forEach((noteData) => {
@@ -435,7 +435,7 @@ class SaveInterface {
     saveBlockArtworkPNG(activity) {
         activity.printBlockPNG().then((pngDataUrl) => {
             activity.save.download("png", pngDataUrl, null);
-        })
+        });
     }
 
     /**
@@ -777,6 +777,6 @@ class SaveInterface {
 }
 
 
-if (typeof module !== 'undefined' && module.exports) {
+if (typeof module !== "undefined" && module.exports) {
     module.exports = { SaveInterface };
 }