Fix duplicate methodRefactor color block logic: remove redundant methods, unify pixel data handling, and improve documentation #4799
+4,695
−4,028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Eliminated duplicate getPixelDataFromMedia method by merging functionality into getPixelData - Updated arg method to use unified getPixelData method - Fixed color component indexing in GetBlueBlock and GetGreenBlock - Improved code organization and documentation - Added proper error handling - Maintained backward compatibility with existing tests This change makes the code more maintainable by following DRY principles while preserving all existing functionality.
…el data handling - Removed duplicate getPixelDataFromMedia method - Merged pixel data handling into unified getPixelData method - Updated arg method to use the consolidated getPixelData - Improved error handling and documentation - Fixed RGB component indexing in GetBlueBlock and GetGreenBlock - Made code more maintainable and DRY This change eliminates code duplication while preserving all functionality and improving error handling across the SensorsBlocks implementation.
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the color sensor logic in SensorsBlocks.js by cleaning up duplicate methods, fixing RGB component issues, and improving documentation clarity.
🔧 Changes Made
🗑️ Removed redundant method getPixelDataFromMedia()
🔄 Unified pixel data extraction into a single method getPixelData()
🎨 Fixed incorrect RGB component indexing in color blocks
🧾 Improved JSDoc comments for clarity and accuracy
⚙️ Enhanced error handling for invalid or missing media blocks
✨ Minor refactoring for readability and consistency
✅ Benefits
Reduces code duplication and complexity
Improves maintainability and readability
Ensures accurate RGB value extraction
Provides better documentation for future contributors
🧪 Testing
Verified color sensor outputs manually
Confirmed no regressions in color block functionality
All unit tests passed successfully
📎 File Updated
SensorsBlocks.js