Skip to content

Conversation

@Garneauma
Copy link
Collaborator

@Garneauma Garneauma commented Jul 9, 2024

Dependent on PR #2410 being merged.

Changes related to: WET-467

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'adore la restructuration que tu as fais du markup de la page. Good job.

Il va falloir ajouter une page d'exemple soit pour le dernier menu item ou soit pour un des avants derniers item du menu. Ceci afin de bien voir l'effet de la class "active" qui est utilisé dans le menu de gauche pour identifier l'item courant.

@duboisp duboisp assigned Garneauma and unassigned duboisp Jul 16, 2024
@duboisp duboisp added this to the v15.5.0 milestone Aug 12, 2024
@duboisp duboisp added the Query: Project item Part of a github project label Aug 13, 2024
@duboisp duboisp modified the milestones: v15.5.0, v15.6.0 Aug 14, 2024
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Is that theme page should still have the "Top menu" button?

If not, then the "sign in" button for the "Jobs" theme example need to be at the same line of the breadcrumb. (I didn't tested that use case if that is already supported or not yet.)

@duboisp
Copy link
Member

duboisp commented Aug 30, 2024

@Garneauma can you add in the request description our internal reference number associated with this PR? thanks

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review checklist:

  • feature integration
  • documentation - All good except the following:
    • Check if instruction are specified about adding "active" css class to the corresponding menu item
    • Revise the static text list to ensure it is complete
    • If we have the info, update the DTO link to the guidance or point for now to their generic page
  • code - Check with only the following to note:
    • Concern raised about the element id gridContainer when we will implement in MWS.
  • technical test - Completed and pass
  • functional check - Completed, except
    • Please add an explicit removal of the top menu. This can be a JS check/function. We don't know if actually the removal are going to be completed before this.
  • versioning impact - This is a major change for the template, but a patch for GCWeb
  • maintenance plan - Nothing to note
  • Previous comment/concerns - Was all addressed

duboisp
duboisp previously approved these changes May 9, 2025
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Previous comment/concerns - Was all addressed
  • Confirmed that the top menu are going to co-exist with this page.
  • Functional check - completed En & FR
  • documentation - lgtm
  • code - Updated line was reviewed. If the gridContainer become an issue when implementing in a new template 'Editable Template', we will address that later, for now it should work as expected.

We will be able to merge, once we have the ok from BA or/and DTO via our internal ticket.

@duboisp
Copy link
Member

duboisp commented May 23, 2025

@BeraJosh as discussed, for you review. A simple comment saying "all good" will be sufficient. Thanks.

@Garneauma Garneauma added this to the v16.7.0 milestone May 26, 2025
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed last committed change and tested locally and it does looks good.

Last step is to get a security clearance by PP security team prior to merge this PR.

cc @BeraJosh @Ricokola

@duboisp duboisp removed their assignment May 27, 2025
@Garneauma Garneauma merged commit b090fdb into wet-boew:master May 28, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Change required to Review in progress in Canada.ca theme optimization May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Query: Project item Part of a github project

Projects

Status: Review in progress

Development

Successfully merging this pull request may close these issues.

3 participants