ci: copy split up CI jobs from upstream #2525
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
commented
Mar 14, 2025
| - name: Checkout wet-boew latest build | ||
| - uses: actions/checkout@v4 | ||
| if: ${{ env.ACT }} |
Member
Author
There was a problem hiding this comment.
Because of the condition it doesn't look like this is currently being run. Maybe better to just remove the change or this step
Member
Author
|
@Garneauma seems like there are issues with the HTML linting for broken links. Does it make sense to split that one out to a separate PR/branch so you can push some cleanups, but leave the rest of the jobs in this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request(PR) do?
Copied the jobs from wet-boew and adjusted the paths a little based on the layout. I left some of the sass-lint parts, even though there is a separate PR to remove those.
I tweaked the core CI job use the actions/checkout plugin rather than the clone/copy, but maybe that won't work.
Contribution category (please only choose one)
General checklist
Related issues