support assigning contract in ticket update rules (#20693)

* support assigning contract in ticket update rules

* do not remove existing

Author: cconard96

CHANGELOG.md

@@ -8,6 +8,7 @@ The present file will list all changes made to the project; according to the
 ### Added
 
 ### Changed
+- Assign contract Ticket rule action now works with update rules.
 
 ### Deprecated
 

phpunit/functional/TicketTest.php

@@ -37,6 +37,7 @@
 use CommonITILActor;
 use CommonITILObject;
 use Computer;
+use Contract;
 use CronTask;
 use DbTestCase;
 use Entity;
@@ -54,6 +55,7 @@
 use Supplier_Ticket;
 use Symfony\Component\DomCrawler\Crawler;
 use Ticket;
+use Ticket_Contract;
 use Ticket_User;
 use TicketValidation;
 use User;
@@ -8289,4 +8291,37 @@ public function testSelfServiceFormRendering(): void
         // trigger in case of issues.
         $this->assertNotEmpty($content);
     }
+
+    public function testHandleAddContracts()
+    {
+        $this->login();
+        $contract_1 = $this->createItem(Contract::class, [
+            'name' => 'Contract 1',
+            'entities_id' => $this->getTestRootEntity(true),
+        ]);
+        $contract_2 = $this->createItem(Contract::class, [
+            'name' => 'Contract 2',
+            'entities_id' => $this->getTestRootEntity(true),
+        ]);
+
+        $ticket = $this->createItem(Ticket::class, [
+            'name' => 'Ticket with contracts',
+            'content' => 'test',
+            'entities_id' => $this->getTestRootEntity(true),
+            '_contracts_id' => $contract_1->getID(),
+        ]);
+        $tc = new Ticket_Contract();
+        $linked_contracts = array_values($tc->find(['tickets_id' => $ticket->getID()]));
+        $this->assertCount(1, $linked_contracts);
+        $this->assertEquals($contract_1->getID(), $linked_contracts[0]['contracts_id']);
+
+        $ticket->update([
+            'id' => $ticket->getID(),
+            '_contracts_id' => $contract_2->getID(),
+        ]);
+        $linked_contracts = array_values($tc->find(['tickets_id' => $ticket->getID()]));
+        $this->assertCount(2, $linked_contracts);
+        $this->assertContains($contract_1->getID(), array_column($linked_contracts, 'contracts_id'));
+        $this->assertContains($contract_2->getID(), array_column($linked_contracts, 'contracts_id'));
+    }
 }

src/Ticket.php

@@ -1639,6 +1639,21 @@ public function computeTakeIntoAccountDelayStat()
         return 0;
     }
 
+    private function handleContractInputs()
+    {
+        $contracts_id = $this->input['_contracts_id'] ?? 0;
+        if (!is_array($contracts_id)) {
+            $contracts_id = [$contracts_id];
+        }
+        $contracts_id = array_filter($contracts_id, static fn($val) => ((int) $val > 0));
+        $ticketcontract = new Ticket_Contract();
+        foreach ($contracts_id as $contract_id) {
+            $ticketcontract->add([
+                'contracts_id' => $contract_id,
+                'tickets_id'   => $this->getID(),
+            ]);
+        }
+    }
 
     public function post_updateItem($history = true)
     {
@@ -1788,6 +1803,9 @@ public function post_updateItem($history = true)
             );
         }
 
+        // Add linked contract
+        $this->handleContractInputs();
+
         // Add linked project
         $projects_ids = $this->input['_projects_id'] ?? [];
         foreach ($projects_ids as $projects_id) {
@@ -2196,14 +2214,7 @@ public function post_addItem()
         }
 
         // Add linked contract
-        $contracts_id = $this->input['_contracts_id'] ?? 0;
-        if ($contracts_id) {
-            $ticketcontract = new Ticket_Contract();
-            $ticketcontract->add([
-                'contracts_id' => $this->input['_contracts_id'],
-                'tickets_id'   => $this->getID(),
-            ]);
-        }
+        $this->handleContractInputs();
 
         // Add linked project
         $projects_ids = $this->input['_projects_id'] ?? [];