Skip to content

Commit a7b57b9

Browse files
trashercedric-anne
andauthored
Apply suggestions from code review
Co-authored-by: Cédric Anne <[email protected]>
1 parent abf345b commit a7b57b9

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

src/IPNetwork.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ public function rawSearchOptions()
143143

144144

145145
/**
146-
* @return false|IPAddress|null
146+
* @return false|IPAddress
147147
*/
148148
public function getAddress()
149149
{
@@ -159,7 +159,7 @@ public function getAddress()
159159

160160

161161
/**
162-
* @return false|IPNetmask|null
162+
* @return false|IPNetmask
163163
*/
164164
public function getNetmask()
165165
{
@@ -175,7 +175,7 @@ public function getNetmask()
175175

176176

177177
/**
178-
* @return false|IPAddress|null
178+
* @return false|IPAddress
179179
*/
180180
public function getGateway()
181181
{
@@ -925,6 +925,8 @@ public static function checkNetworkRelativity(
925925
* (default '')
926926
*
927927
* @return void
928+
*
929+
* @TODO Deprecate the `$excludeBroadcastAndNetwork`, it is never used.
928930
**/
929931
public function computeNetworkRange(&$start, &$end = null, $excludeBroadcastAndNetwork = '')
930932
{

src/NetworkAlias.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,6 @@ public static function getHTMLTableHeader(
165165
* @param CommonDBTM|null $item
166166
* @param HTMLTableCell|null $father
167167
* @param array $options
168-
* @return void
169168
*
170169
* @return void
171170
*/

src/NetworkPortInstantiation.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,8 @@ class NetworkPortInstantiation extends CommonDBChild
5959
public $auto_message_on_action = false;
6060

6161
// From CommonDBChild
62-
/** @var class-string<CommonDBTM> string */
6362
public static $itemtype = NetworkPort::class;
64-
/** @var string */
6563
public static $items_id = 'networkports_id';
66-
/** @var bool */
6764
public $dohistory = false;
6865

6966
// Instantiation properties

0 commit comments

Comments
 (0)