hide optionallyFollowedBy(Parser<UnaryOperator>). Not consistent with the other members of the overload family

Author: fluentfuture

dot-parse/src/main/java/com/google/common/labs/parse/OperatorTable.java

@@ -195,7 +195,7 @@ private static final class Infixl<T> extends Binary<T> {
 
   private static final class Infixn<T> extends Binary<T> {
     @Override public Parser<T> makeExpressionParser(Parser<T> operand) {
-      return operand.optionallyFollowedBy(opWithRightHandSide(operand));
+      return operand.optionalPostfix(opWithRightHandSide(operand));
     }
   }
 

dot-parse/src/main/java/com/google/common/labs/parse/Parser.java

@@ -22,7 +22,7 @@
 import static com.google.mu.util.stream.MoreStreams.whileNotNull;
 import static java.util.Arrays.stream;
 import static java.util.Objects.requireNonNull;
-import static java.util.function.Function.identity;
+import static java.util.function.UnaryOperator.identity;
 import static java.util.stream.Collectors.collectingAndThen;
 import static java.util.stream.Collectors.counting;
 import static java.util.stream.Collectors.joining;
@@ -763,18 +763,11 @@ public final Parser<T> optionallyFollowedBy(String suffix) {
    * by {@code suffix}.
    */
   public final Parser<T> optionallyFollowedBy(String suffix, Function<? super T, ? extends T> op) {
-    return optionallyFollowedBy(string(suffix).thenReturn(op::apply));
+    return optionalPostfix(string(suffix).thenReturn(op::apply));
   }
 
-  /**
-   * Returns an equivalent parser except it will optionally apply the unary operator resulting from
-   * {@code suffix}.
-   */
-  public final Parser<T> optionallyFollowedBy(Parser<? extends UnaryOperator<T>> suffix) {
-    return sequence(
-        this,
-        suffix.orElse(null),
-        (operand, operator) -> operator == null ? operand : operator.apply(operand));
+  final Parser<T> optionalPostfix(Parser<UnaryOperator<T>> suffix) {
+    return sequence(this, suffix.orElse(identity()), (operand, op) -> op.apply(operand));
   }
 
   /** A form of negative lookahead such that the match is rejected if followed by {@code suffix}. */

dot-parse/src/test/java/com/google/common/labs/parse/ParserTest.java

@@ -4268,7 +4268,7 @@ static Parser<ResourceNamePattern> parser() {
               subpath)
           .atLeastOnceDelimitedBy("/")
           .map(ResourceNamePattern::new)
-          .optionallyFollowedBy(revision.map(v -> pattern -> pattern.withRevision(v)));
+          .optionalPostfix(revision.map(v -> pattern -> pattern.withRevision(v)));
     }
 
     static ResourceNamePattern parse(String path) {