The `Google Analytics was successfully set up` toast notice is not visible in the Key Metrics Setup screen

[abdelmalekkkkk]

Bug Description

When landing on the Key Metrics Setup screen after setting up Google Analytics, a toast notice should appear at the bottom right of the screen with the text "Google Analytics was successfully set up". It's currently correctly rendered, but the newly added footer hides it.

Steps to reproduce

1. Set up Site Kit with setupFlowRefresh enabled
2. Complete the Analytics setup
3. Upon landing on the Key Metrics Setup screen, notice that the expect toast notice is not visible

Screenshots

Additional Context

• PHP Version:
• OS: [e.g. iOS]
• Browser: [e.g. chrome, safari]
• Plugin Version: [e.g. 22]
• Device: [e.g. iPhone6]

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• When running through the steps to reproduce, the "Google Analytics was successfully set up" toast should appear on the Key Metrics setup screen.

Implementation Brief

• Update the ToastNotice styles in assets/sass/components/toast-notice/_googlesitekit-toast-notice.scss
  • Add a z-index: 1
• Update the footer styles in assets/sass/components/user-input/googlesitekit-user-input-module.scss
  • Update the horizontal padding of .googlesitekit-user-input__footer from 28px to 23px

Test Coverage

• Inspect and update failing VRTs.

QA Brief

Changelog entry

[nfmohit]

Thank you for drafting the IB, @abdelmalekkkkk!

Update the footer styles in assets/sass/components/user-input/googlesitekit-user-input-module.scss

• Update the horizontal padding of .googlesitekit-user-input__footer from 28px to 23px in line 123

Three concerns:

1. We shouldn't be reducing the padding in this issue, as it is not technically related to the ACs here. Using z-index as you've specified should be sufficient.
2. Even if we did update the padding here, doing so in a generic way would also change it for the UserInputApp, which is something we don't want (unless confirmed with Sigal or mutually agreed by the wider team), as that is a separate component and we're re-using its components here.
3. We shouldn't be too verbose, such as specifying line numbers in the IB. The lines may change at the time of implementation, so a general direction is sufficient.

Also, could you please add an estimate?

Thank you!

[abdelmalekkkkk]

Thanks @nfmohit. I discussed the padding issue with Tom here.

As for the footer, I think the padding is wrong everywhere from what I could find (SFR designs and the original footer component design), so that should be fine.

Please let me know your thoughts. Thanks!

[nfmohit]

That sounds good, thanks for pointing that out!

We're still missing an estimate, though. Could you kindly add one? Thanks!