-
Notifications
You must be signed in to change notification settings - Fork 326
Description
Feature Description
The dashboard EnhancedConversionsNotification in both Analytics-4 and Ads modules is currently using PRIORITY.INFO but is part of the NOTIFICATION_GROUPS.SETUP_CTAS group. For consistency with other dashboard notifications in the SETUP_CTAs queue (such as ConsentModeSetupCTABanner, AudienceSegmentationIntroductoryOverlayNotification, etc.), this notification should use PRIORITY.SETUP_CTA_HIGH instead.
This improves code consistency and makes the priority naming convention align with the notification group it belongs to. All other dashboard notifications in the SETUP_CTAS group use priorities that begin with SETUP_CTA_*.
Bug Bashing Asana ticket for reference.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- The
ENHANCED_CONVERSIONS_NOTIFICATION_ANALYTICSdashboard notification in the Analytics-4 module usesPRIORITY.SETUP_CTA_HIGHinstead ofPRIORITY.INFO. - The
ENHANCED_CONVERSIONS_NOTIFICATION_ADSdashboard notification in the Ads module usesPRIORITY.SETUP_CTA_HIGHinstead ofPRIORITY.INFO. - The dashboard notification behavior remains unchanged.
Implementation Brief
- In
assets/js/modules/analytics-4/index.js, changepriority: PRIORITY.INFOtopriority: PRIORITY.SETUP_CTA_HIGHfor theENHANCED_CONVERSIONS_NOTIFICATION_ANALYTICSnotification. - In
assets/js/modules/ads/index.js, changepriority: PRIORITY.INFOtopriority: PRIORITY.SETUP_CTA_HIGHfor theENHANCED_CONVERSIONS_NOTIFICATION_ADSnotification.
Test Coverage
- No new tests are required.
- Existing tests for both
EnhancedConversionsNotificationcomponents should continue to pass.