Skip to content

Add external icon to "Learn more" links in Enhanced Conversions notices #11744

@hussain-t

Description

@hussain-t

Feature Description

The "Learn more" links in Enhanced Conversions notices (both dashboard notifications and settings notices) currently hide the external link indicator by using the hideExternalIndicator prop. This is inconsistent with other notices and links throughout Site Kit, which use the external icon to indicate that the link opens an external URL.

The external indicator should be shown for these links to improve UX consistency and better inform users that clicking the "Learn more" link will navigate to an external documentation page.

This affects the following components:

  • Analytics-4 dashboard notification (EnhancedConversionsNotification)
  • Ads dashboard notification (EnhancedConversionsNotification)
  • Analytics-4 settings notice (EnhancedConversionsSettingsNotice)
  • Ads settings notice (EnhancedConversionsSettingsNotice)

Bug Bashing Asana ticket for reference.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The "Learn more" link in the Analytics-4 Enhanced Conversions dashboard notification displays the external link indicator.
  • The "Learn more" link in the Ads Enhanced Conversions dashboard notification displays the external link indicator.
  • The "Learn more" link in the Analytics-4 Enhanced Conversions settings notice displays the external link indicator.
  • The "Learn more" link in the Ads Enhanced Conversions settings notice displays the external link indicator.

Implementation Brief

  • Remove hideExternalIndicator prop from the LearnMoreLink component in assets/js/modules/analytics-4/components/notifications/EnhancedConversionsNotification.js.
  • Remove hideExternalIndicator prop from the LearnMoreLink component in assets/js/modules/ads/components/notifications/EnhancedConversionsNotification.js.
  • Remove hideExternalIndicator prop from the LearnMoreLink component in assets/js/modules/analytics-4/components/settings/EnhancedConversionsSettingsNotice.js.
  • Remove hideExternalIndicator prop from the LearnMoreLink component in assets/js/modules/ads/components/settings/EnhancedConversionsSettingsNotice.js.

Test Coverage

  • Update VRT to approve new images showing the external icon.

QA Brief

Changelog entry

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1Medium priorityTeam MIssues for Squad 2Type: EnhancementImprovement of an existing feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions