Skip to content

Conversation

@artur-beznosyuk-verkada
Copy link
Contributor

Fix for issue #283

This should guarantee exactly the same behavior but avoids edge case performance issues. I outlined few other suggestions in the task

@google-cla
Copy link

google-cla bot commented Oct 22, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@artur-beznosyuk-verkada
Copy link
Contributor Author

I signed CLA and triggered rescan

@braydonk
Copy link
Collaborator

Thanks for the PR. What effect did this have on the performance on that large file?

Copy link
Collaborator

@braydonk braydonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to hit approve

@braydonk braydonk merged commit 00c0bef into google:main Oct 22, 2025
5 checks passed
@artur-beznosyuk-verkada
Copy link
Contributor Author

Thanks for the quick acceptance :) with using Repeat the runtime on the same file went from ~60-70 minutes to about 10 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants