-
Notifications
You must be signed in to change notification settings - Fork 105
GridapMakie as an extension to Gridap #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Tests fail because:
|
|
Hi @ovanvincq thank you for the work. I do have some preliminary comments:
|
|
Hi @JordiManyer I made the changes in the documentation. For OpenGL, I think you need to change A quick question: does a Triangulation{0,N} with N>1 exist? |
|
As I said, we can split the tests and run the ones we already had in GridapMakie.jl, I'll unify them again in a later PR. Basically copy paste the GridapMakie CI. You could also do the CairoMakie workaround, of it works.
Yes, a triangulatin of points would be Triangulation{0,D} with D the ambient dimension. I don't know if anyone would ever want to use it, but that is what it would be. I would say it's not super important to support that on Makie. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1121 +/- ##
==========================================
- Coverage 89.23% 87.27% -1.97%
==========================================
Files 208 211 +3
Lines 26196 26457 +261
==========================================
- Hits 23377 23091 -286
- Misses 2819 3366 +547 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@JordiManyer I copied the CI file from GridapMakie and the test succeeded |
Hi,
This PR is a proposal to transform
GridapMakie.jlinto an extension ofGridap.jl.I named this extension
GridapMakieExt.It is compatible with
Makie.jlv0.24 and not with previous versions because the recipes use the newComputeGraphinterface.