Contest winner through email #81
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajivtitus
reviewed
Aug 5, 2021
| const user = await User.findById(userID); | ||
| const receiver = await User.findById(receiverID); | ||
| if (!user || !receiver){ | ||
| return res.status(500).json({ |
Contributor
There was a problem hiding this comment.
Please update this to a 'Not found' status code
rajivtitus
reviewed
Aug 5, 2021
| } | ||
| const contest = await Contest.findById(contestID); | ||
| if (!contest){ | ||
| return res.status(500).json({ |
rajivtitus
reviewed
Aug 5, 2021
| let success = false; | ||
| const { receiverID } = req.body; | ||
| try { | ||
| const user = await User.findById(userID); |
Contributor
There was a problem hiding this comment.
What is the reason for searching up a 'user' here? If he doesn't exist, how would he have logged in? :)
rajivtitus
approved these changes
Aug 5, 2021
Contributor
rajivtitus
left a comment
rajivtitus
left a comment
There was a problem hiding this comment.
LGTM! Please address comments before meging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does (required):
Screenshots / Videos (required):
Any information needed to test this feature (required):
Any issues with the current functionality (optional):