Skip to content

Conversation

@galgeek
Copy link
Contributor

@galgeek galgeek commented Jun 9, 2025

No description provided.

@galgeek galgeek self-assigned this Jun 9, 2025
@galgeek galgeek marked this pull request as draft June 9, 2025 23:37
@vbanos
Copy link
Contributor

vbanos commented Jun 10, 2025

I think that 30 is already too much.
In production we always use values < 10 from my experience.
Why increase it to 60?

@galgeek galgeek marked this pull request as ready for review June 24, 2025 22:08
@galgeek
Copy link
Contributor Author

galgeek commented Jun 24, 2025

Thanks, @vbanos! It's perhaps more important for our application to get the page header, at the expense of a larger timeout. I'll keep your recommendation in mind, for a possible revision.

@galgeek galgeek requested a review from Copilot June 25, 2025 01:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the HEADER_REQUEST_TIMEOUT constant in the BrozzlerWorker class to provide a longer timeout period for header requests.

  • Increase HEADER_REQUEST_TIMEOUT from 30 to 60
  • Update applied in brozzler/worker.py
Comments suppressed due to low confidence (1)

brozzler/worker.py:57

  • Increasing HEADER_REQUEST_TIMEOUT to 60 changes the behavior of header requests. Please verify that this update aligns with system expectations and coordinated timeout handling across the application.
    HEADER_REQUEST_TIMEOUT = 60

@galgeek galgeek merged commit ba9e4f1 into internetarchive:master Oct 7, 2025
5 checks passed
@mistydemeo mistydemeo mentioned this pull request Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants