fix: the value of warcVer changed unexpectedly (#154)

yzqzss · web-flow · commit 52f00a31c4c4 · 2025-11-03T02:22:04.000-08:00
The lifecycle of warcVer spans multiple `readUntilDelim()` calls, and changes in the underlying buffer (intermediateBuf) data can cause unexpected to the warcVer.
diff --git a/read.go b/read.go
@@ -254,7 +254,8 @@ func (r *Reader) ReadRecord(opts ...ReadOpts) (*Record, error) {
 		}
 	}
 
-	warcVer, _, err := readUntilDelim(r.bufReader, []byte("\r\n"))
+	_warcVer, _, err := readUntilDelim(r.bufReader, []byte("\r\n"))
+	warcVer := string(_warcVer) // clone to avoid changes in underlying buffer
 	if err != nil {
 		if err == io.EOF && len(warcVer) == 0 {
 			// treat as EOF for safety if member present but empty

Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,8 @@ func (r Reader) ReadRecord(opts ...ReadOpts) (Record, error) {`
`254`	`254`	`}`
`255`	`255`	`}`
`256`	`256`
`257`		`- warcVer, _, err := readUntilDelim(r.bufReader, []byte("\r\n"))`
	`257`	`+ _warcVer, _, err := readUntilDelim(r.bufReader, []byte("\r\n"))`
	`258`	`+ warcVer := string(_warcVer) // clone to avoid changes in underlying buffer`
`258`	`259`	`if err != nil {`
`259`	`260`	`if err == io.EOF && len(warcVer) == 0 {`
`260`	`261`	`// treat as EOF for safety if member present but empty`