Beautify 404 page #4827
Open
Beautify 404 page #4827
+2,538
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broquemonsieur
requested review from
SamantazFox
and removed request for
a team
SamantazFox
reviewed
Aug 14, 2024
src/invidious/helpers/errors.cr
Outdated
Comment on lines
77
to
78
| unfound_tv_box_dark_theme = File.read("assets/404_tv_box_dark_theme.svg") | ||
| unfound_tv_box_light_theme = File.read("assets/404_tv_box_light_theme.svg") |
Member
There was a problem hiding this comment.
Please, don't do that! Instead, put the file URL in the src attribute in the HTML, and let the browser and web server properly handle caching.
If you load the image from disk each time you have to show this error, you'll waste all file descriptors the server can have.
ChunkyProgrammer
approved these changes
Oct 6, 2024
| <%= error_message %> | ||
| <% if dark_mode == "dark" %> | ||
| <div style="width: 100px; height: auto;"> | ||
| <img src="/404_tv_box_dark_theme.svg" alt="SVG Image" style="width: 100px; height: auto;"> |
Contributor
There was a problem hiding this comment.
An empty alt should be used instead unless there's information in the image that should be conveyed to users that use a screenreader.
Suggested change
| <img src="/404_tv_box_dark_theme.svg" alt="SVG Image" style="width: 100px; height: auto;"> | |
| <img src="/404_tv_box_dark_theme.svg" alt="" style="width: 100px; height: auto;"> |
| </div> | ||
| <% else %> | ||
| <div style="width: 100px; height: auto;"> | ||
| <img src="/404_tv_box_light_theme.svg" alt="SVG Image" style="width: 100px; height: auto;"> |
Contributor
There was a problem hiding this comment.
Same thing here:
Suggested change
| <img src="/404_tv_box_light_theme.svg" alt="SVG Image" style="width: 100px; height: auto;"> | |
| <img src="/404_tv_box_light_theme.svg" alt="" style="width: 100px; height: auto;"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A classic sign of a hip website is their 404 page. Making them fun or clever has been trending upward since 2010.
This @SamantazFox-approved graphic resembles a Video Input error for Cable TVs to represent a
video_idthat is not found