RoPE implementation with a shakespeare-char-rope test #590
+91
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Didn't check for checkpoint continuations. |
|
Hi, |
klei22
added a commit
to klei22/nanoGPT
that referenced
this pull request
Sep 14, 2025
…and_languages_to_tokenizer_analysis_scripts Add additional languages and scripts for analysis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without RoPE:
With RoPE:
Can still be used without RoPE normally. Everything should work as before. Only if in the config file you add use_rope flag, then it will use RoPE instead of the wpe matrix. rope_base is also a configurable value.
Tested on 4090, so has different mfu (because the calculation is based on A100).