-
Notifications
You must be signed in to change notification settings - Fork 166
Open
Description
Checking icons implemented in #2332 is awesome, but I missed three requirements when reviewing it:
- it should not run when
required (which is why it runs onpostinstallas well), only when run withnode- this is tricky, I don't know what to do here other than create our own development CLI using a tool like
yargs, as a separate private package
- this is tricky, I don't know what to do here other than create our own development CLI using a tool like
- it should only run in
pre-commitand on CI- we should remove it from
build - we should add it to
test-ci, probably right at the beginning
- we should remove it from
- it should not have output, it's not necessary
vepor
Metadata
Metadata
Assignees
Labels
No labels