refactor(main): skip success exec (#4162)

Author: cuisongliu

pkg/apply/applydrivers/apply_drivers_default.go

@@ -171,7 +171,7 @@ func (c *Applier) updateStatus(clusterErr error, appErr error) {
 			cmdCondition = v2.NewFailedCommandCondition(appErr.Error())
 		}
 	} else if len(c.RunNewImages) > 0 {
-		cmdCondition = v2.NewSuccessCommandCondition()
+		return
 	}
 	cmdCondition.Images = c.RunNewImages
 	c.ClusterDesired.Status.CommandConditions = v2.UpdateCommandCondition(c.ClusterDesired.Status.CommandConditions, cmdCondition)

pkg/types/v1beta1/cluster.go

@@ -187,16 +187,6 @@ type CommandCondition struct {
 	Message string `json:"message,omitempty"`
 }
 
-func NewSuccessCommandCondition() CommandCondition {
-	return CommandCondition{
-		Type:              CommandConditionTypeSuccess,
-		Status:            v1.ConditionTrue,
-		LastHeartbeatTime: metav1.Now(),
-		Reason:            "Apply Command",
-		Message:           "Applied to cluster successfully",
-	}
-}
-
 func NewFailedCommandCondition(message string) CommandCondition {
 	return CommandCondition{
 		Type:              CommandConditionTypeError,