fix(init.sh): streamline image pulling and saving process with associative array #5872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ative array Signed-off-by: cuisongliu <[email protected]>
cuisongliu
force-pushed
the
fix-save-tars
branch
from
56e0b19 to
c0f92fa
Compare
bxy4543
approved these changes
Aug 25, 2025
Zllinc
pushed a commit
to Zllinc/sealos
that referenced
this pull request
Sep 5, 2025
…ative array (labring#5872) Signed-off-by: cuisongliu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the image pulling and saving logic in
deploy/cloud/init.shto make it more maintainable and scalable. Instead of listing each image and its tar file individually, the script now uses an associative array to manage image-to-tar mappings and loops over them to perform the operations. This reduces code duplication and makes it easier to add or modify images in the future.Refactoring and maintainability improvements:
retryPullImageandsealos savecalls with a single associative array (images) mapping image names to their respective tar files, streamlining the process.tarsdirectory is created before saving images, improving robustness.