refactor(golint): update code style and improve error handling across multiple files #6105
Conversation
github-actions
bot
added
area/imageCRIShim
cuisongliu
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6105 +/- ##
==========================================
+ Coverage 61.86% 64.12% +2.25%
==========================================
Files 8 8
Lines 653 722 +69
==========================================
+ Hits 404 463 +59
- Misses 202 212 +10
Partials 47 47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| func (c *ScaleProcessor) RunGuest(cluster *v2.Cluster) error { | ||
| logger.Info("Executing pipeline RunGuest in ScaleProcessor.") | ||
| hosts := append(c.MastersToJoin, c.NodesToJoin...) | ||
| hosts := append(append([]string{}, c.MastersToJoin...), c.NodesToJoin...) |
There was a problem hiding this comment.
Can we use slices.Clone followed by append?
| func (c ScaleProcessor) UnMountRootfs(cluster *v2.Cluster) error { | ||
| logger.Info("Executing pipeline UnMountRootfs in ScaleProcessor.") | ||
| hosts := append(c.MastersToDelete, c.NodesToDelete...) | ||
| hosts := append(append([]string{}, c.MastersToDelete...), c.NodesToDelete...) |
There was a problem hiding this comment.
Same issue, and there are other places as well.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| time.Sleep(trySleepTime * time.Duration(2*i+1)) | ||
| } | ||
| return fmt.Errorf("retry action timeout: %v", err) | ||
| return fmt.Errorf("retry action timeout: %w", err) | ||
| } | ||
|
|
||
| // RetryWithBackoff provides exponential backoff retry with jitter | ||
| func RetryWithBackoff(maxAttempts int, baseDelay time.Duration, action func() error) error { | ||
| var lastErr error | ||
| for attempt := range maxAttempts { | ||
| if err := action(); err == nil { | ||
| return nil |
There was a problem hiding this comment.
The new loops call for i := range tryTimes (and similarly range maxAttempts) where tryTimes and maxAttempts are integers. In Go an int is not iterable, so this code does not compile at all; the range keyword only works with arrays, slices, maps, strings or channels. The original counted for loop compiled correctly. Please switch back to a standard for i := 0; i < tryTimes; i++ style loop (and likewise for the other two retry helpers) so that the package builds.
Useful? React with 👍 / 👎.
…e files Signed-off-by: cuisongliu <[email protected]>
…tions Signed-off-by: cuisongliu <[email protected]>
Signed-off-by: cuisongliu <[email protected]>
…cross multiple files Signed-off-by: cuisongliu <[email protected]>
…multiple files Signed-off-by: cuisongliu <[email protected]>
Signed-off-by: cuisongliu <[email protected]>
Signed-off-by: cuisongliu <[email protected]>
…etry and runner modules Signed-off-by: cuisongliu <[email protected]>
Signed-off-by: cuisongliu <[email protected]>
…s across multiple files Signed-off-by: cuisongliu <[email protected]>
…s across multiple files Signed-off-by: cuisongliu <[email protected]>
2 participants
…e files