MariaDB: allow custom service name (MARIADB_SERVICE=) #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new environment variable 'MARIADB_SERVICE' can be used
if you have a custom Docker Compose service name for your database.
For example, if your Docker Compose has a service called 'db', just do this
in your .env file:
MARIADB_SERVICE=db
Closes laravel#816 (comment)
Member
|
Thanks for your pull request to Laravel! Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include. If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions! |
Author
|
As a package, it sounds impossible. This is a Bash script, and it had hardcoded service names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new environment variable
MARIADB_SERVICEcan be used if you have a custom Docker Compose service name for your database.For example, if your Docker Compose has a service called
db, just do this in your .env file:This change is backward-compatible. The default is still
mariadb.Closes #816 (comment)