undo different conn return based on limits

Author: tabcat

packages/libp2p/src/connection-manager/dial-queue.ts

@@ -334,8 +334,7 @@ export class DialQueue {
             return false
           })
 
-          // return existing, open connection to peer if equal or better limits
-          if (existingConnection?.status === 'open' && (existingConnection?.limits == null || conn?.limits != null)) {
+          if (existingConnection?.status === 'open') {
             this.log('already connected to %a', existingConnection.remoteAddr)
             options?.onProgress?.(new CustomProgressEvent('dial-queue:already-connected'))
 

packages/libp2p/test/connection-manager/dial-queue.spec.ts

@@ -414,40 +414,6 @@ describe('dial queue', () => {
     await expect(dialer.dial(addr2)).to.eventually.equal(existingConnection)
   })
 
-  it('should return new connection when existing connection to same peer is worse', async () => {
-    const remotePeer = peerIdFromPrivateKey(await generateKeyPair('Ed25519'))
-    const ip = multiaddr('/ip4/123.123.123.123')
-    const addr1 = ip.encapsulate('/tcp/123')
-    const addr2 = ip.encapsulate('/tcp/321')
-
-    const existingConnection = stubInterface<Connection>({
-      limits: {
-        bytes: 100n
-      },
-      remotePeer,
-      remoteAddr: addr1.encapsulate(`/p2p/${remotePeer}`),
-      status: 'open'
-    })
-
-    const newConnection = stubInterface<Connection>({
-      limits: undefined,
-      remotePeer,
-      remoteAddr: addr2.encapsulate(`/p2p/${remotePeer}`),
-      status: 'open'
-    })
-
-    const connections = new PeerMap<Connection[]>()
-    connections.set(remotePeer, [existingConnection])
-
-    components.transportManager.dialTransportForMultiaddr.callsFake(ma => {
-      return stubInterface<Transport>()
-    })
-    components.transportManager.dial.callsFake(async (ma, opts = {}) => newConnection)
-    dialer = new DialQueue(components, { connections })
-
-    await expect(dialer.dial(addr2)).to.eventually.equal(newConnection)
-  })
-
   it('should respect user dial signal over default timeout if it is passed', async () => {
     const dialTimeout = 10
     const userTimeout = 500