Skip to content

Commit 85d7d7b

Browse files
committed
fix: add no-module to openssl static build
Ever since the update to openssl 3.x we have been building static openssl ever so slightly incorrect. Without the `no-module` configuration option openssl still tries to provide some non-core modules (like the legacy provider) as a shared library. However luvi has no way to bundle this, and so ever since the update to openssl 3.x we have been unable to use any of the legacy ciphers in luvi. I used the following script to ensure the provided fix actually works for the legacy provider: ```lua local openssl = require 'openssl' print(openssl.errors()) local ctx = openssl.cipher.get('blowfish') -- any cipher provided by legacy works here print(ctx) print(ctx:cipher('123', '456', '789')) ``` Before this fix: ``` C06BE223E67B0000:error:12800067:DSO support routines:dlfcn_load:could not load the shared library:crypto/dso/dso_dlfcn.c:118:filename(.../lib64/ossl-modules/legacy.so): .../lib64/ossl-modules/legacy.so: cannot open shared object file: No such file or directory C06BE223E67B0000:error:12800067:DSO support routines:DSO_load:could not load the shared library:crypto/dso/dso_lib.c:147: C06BE223E67B0000:error:07880025:common libcrypto routines:provider_init:reason(37):crypto/provider_core.c:950:name=legacy openssl.evp_cipher: 0x7be623dd52d8 nil unsupported 50856204 ``` After this fix: ``` openssl.evp_cipher: 0x7fca1a4d8a98 �r���H� ``` Alongside fixing the static build of openssl, this also fixes the intermittent issue with lua-openssl triggering the incompatible pointer types error by silencing the warning, which lua-openssl does internally but only for clang.
1 parent 1d3d906 commit 85d7d7b

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

CMakeLists.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@ if (MINGW)
1818
add_compile_options(-Wno-error=incompatible-pointer-types)
1919
endif ()
2020

21+
if (CMAKE_C_COMPILER_ID MATCHES "Clang|GNU")
22+
add_compile_options(-Wno-incompatible-pointer-types)
23+
endif()
24+
2125
if (UNIX)
2226
add_compile_options(-Wall)
2327
endif ()

deps/openssl.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ else (WithSharedOpenSSL)
1313
OUTPUT_STRIP_TRAILING_WHITESPACE
1414
)
1515

16-
set(OPENSSL_CONFIG_OPTIONS no-tests no-shared no-pinshared no-makedepend --prefix=${CMAKE_BINARY_DIR})
16+
set(OPENSSL_CONFIG_OPTIONS no-tests no-module no-shared no-pinshared no-makedepend --prefix=${CMAKE_BINARY_DIR})
1717
if (OPENSSL_CONFIG_DIR)
1818
message("Using existing OpenSSL configuration directory: ${OPENSSL_CONFIG_DIR}")
1919
set(OPENSSL_CONFIG_OPTIONS ${OPENSSL_CONFIG_OPTIONS} --openssldir=${OPENSSL_CONFIG_DIR})

0 commit comments

Comments
 (0)