refactor: upgrade to child-process-ext

Author: medikoo

lib/get-npm-modules-path.js

@@ -7,10 +7,10 @@ const { resolve } = require("path")
 
 module.exports = memoize(
 	async () => {
-		const { stdout } = await runProgram("npm", ["config", "get", "prefix"], {
+		const { stdoutBuffer } = await runProgram("npm", ["config", "get", "prefix"], {
 			cwd: process.cwd()
 		});
-		const [npmPathPrefix] = String(stdout).split("\n", 1);
+		const [npmPathPrefix] = String(stdoutBuffer).split("\n", 1);
 		if (!npmPathPrefix) throw new Error("Could not resolve npm path prefix");
 		log.notice("npm path prefix: %s", npmPathPrefix);
 		if (process.platform === "win32") return resolve(npmPathPrefix, "node_modules");

lib/run-program.js

@@ -1,36 +1,19 @@
 "use strict";
 
-const isObject  = require("es5-ext/object/is-object")
-    , { spawn } = require("child-process-es6-promise")
-    , split     = require("split")
-    , log       = require("log").get("npm-cross-link");
-
-const winCmdCommands = new Set();
+const isObject = require("es5-ext/object/is-object")
+    , spawn    = require("child-process-ext/spawn")
+    , log      = require("log").get("npm-cross-link");
 
 module.exports = (command, args, options = {}) => {
 	if (!isObject(options)) options = {};
 	const { logger } = options;
-	let promise = spawn(command + (winCmdCommands.has(command) ? ".cmd" : ""), args, {
-		cwd: options.cwd
-	});
-	const { child } = promise;
+	const promise = spawn(command, args, { cwd: options.cwd, split: Boolean(logger) });
 
 	if (logger) {
-		child.stdout
-			.pipe(split(/\r?\n/u, null, { trailing: false }))
-			.on("data", data => logger.info(String(data)));
-		child.stderr
-			.pipe(split(/\r?\n/u, null, { trailing: false }))
-			.on("data", data => logger.notice(String(data)));
+		promise.stdout.on("data", data => logger.info(String(data)));
+		promise.stderr.on("data", data => logger.notice(String(data)));
 	}
 
-	if (process.platform === "win32" && !winCmdCommands.has(command)) {
-		promise = promise.catch(error => {
-			if (error.code !== "ENOENT") throw error;
-			winCmdCommands.add(command);
-			return module.exports(command, args, options);
-		});
-	}
 	return promise.catch(error => {
 		log.warn("%s failed for %s, %O with %#s", command, args, options, error.message);
 		throw error;

lib/setup-repository.js

@@ -37,7 +37,7 @@ module.exports = async (path, repoUrl, options = {}) => {
 			});
 		}
 
-		const { stdout: localStatus } = await runProgram("git", ["status"], { cwd: path });
+		const { stdoutBuffer: localStatus } = await runProgram("git", ["status"], { cwd: path });
 
 		if (
 			tryPull &&

package.json

@@ -8,7 +8,7 @@
   },
   "repository": "medikoo/npm-cross-link",
   "dependencies": {
-    "child-process-es6-promise": "^1.2",
+    "child-process-ext": "2",
     "cjs-module": "^1.5",
     "cli-color": "^1.4",
     "cli-progress-footer": "^1.1",
@@ -23,8 +23,7 @@
     "minimist": "^1.2",
     "semver": "^5.6",
     "tar": "^4.4.8",
-    "timers-ext": "^0.1.7",
-    "split": "^1.0.1"
+    "timers-ext": "^0.1.7"
   },
   "devDependencies": {
     "eslint": "^5.12",