Skip to content

Conversation

@ulgens
Copy link
Contributor

@ulgens ulgens commented Nov 9, 2025

With the help of pyupgrade

Small cleaning before removing Python 3.8 support (EOL)

@ulgens ulgens changed the title Modernizes the code for Python 3.8 Modernize the code for Python 3.8 Nov 9, 2025
@ulgens ulgens force-pushed the pre-python3.8-cleaning branch from d84e838 to 0278664 Compare November 9, 2025 23:23
With the help of pyupgrade
@ulgens ulgens force-pushed the pre-python3.8-cleaning branch from 0278664 to 92abbb9 Compare November 9, 2025 23:24
@ulgens ulgens force-pushed the pre-python3.8-cleaning branch from d6ee816 to 92abbb9 Compare November 10, 2025 10:50
@ulgens
Copy link
Contributor Author

ulgens commented Nov 10, 2025

@Nusnus This will help with 3.8 removal and #1461

Copy link
Collaborator

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should align with python 3.10 already as 3.9 is EOL too.

@ulgens
Copy link
Contributor Author

ulgens commented Nov 10, 2025

@Nusnus I can create other PRs to continue with this work. I think it's better to keep them separete and not to risk have huge PRs that hard to navigate.

@Nusnus
Copy link
Collaborator

Nusnus commented Nov 10, 2025

@Nusnus I can create other PRs to continue with this work. I think it's better to keep them separete and not to risk have huge PRs that hard to navigate.

Sounds great! Thank you!

@ulgens
Copy link
Contributor Author

ulgens commented Nov 10, 2025

@Nusnus Thank you.

Also, about the CI failures,

flower/events.py:18:0: C0103: Variable name "PROMETHEUS_METRICS" doesn't conform to snake_case naming style (invalid-name)

This doesn't come from the changes done in the PR and I didn't care about it much - I'm not even sure why it expects a snake_case naming for a module level variable name. If you have any recommendations, I can handle that in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants