Skip to content

Commit 52b5328

Browse files
committed
Merge branch 'master' into feature/dependabot
2 parents ba8d1a3 + 2413afc commit 52b5328

File tree

6 files changed

+1434
-4
lines changed

6 files changed

+1434
-4
lines changed

src/Agent.Sdk/Knob/AgentKnobs.cs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -899,7 +899,14 @@ public class AgentKnobs
899899
new EnvironmentKnobSource("AZP_USE_ENHANCED_LOGGING"),
900900
new BuiltInDefaultKnobSource("false"));
901901

902-
// Docker Diagnostics
902+
public static readonly Knob EnableEnhancedContainerDiagnostics = new Knob(
903+
nameof(EnableEnhancedContainerDiagnostics),
904+
"When enabled, uses ContainerOperationProviderEnhanced with detailed tracing and duration logging for container operations",
905+
new PipelineFeatureSource("EnableEnhancedContainerDiagnostics"),
906+
new EnvironmentKnobSource("AGENT_ENABLE_ENHANCED_CONTAINER_LOGGING"),
907+
new BuiltInDefaultKnobSource("false"));
908+
909+
903910
public static readonly Knob EnableDockerExecDiagnostics = new Knob(
904911
nameof(EnableDockerExecDiagnostics),
905912
"If true, collect and report comprehensive diagnostics when docker exec commands fail, including container state, resource limits, logs, and platform-specific analysis.",

src/Agent.Worker/Container/DockerCommandManager.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public async Task<DockerVersion> DockerVersion(IExecutionContext context)
8282
}
8383

8484
Version clientVersion = null;
85-
var clientVersionMatchResult = verRegex.Match(serverVersionStr);
85+
var clientVersionMatchResult = verRegex.Match(clientVersionStr);
8686
if (clientVersionMatchResult.Success && !string.IsNullOrEmpty(clientVersionMatchResult.Value))
8787
{
8888
if (!Version.TryParse(clientVersionMatchResult.Value, out clientVersion))
@@ -498,6 +498,7 @@ private static async Task<int> ExecuteDockerCommandAsyncWithRetries(IExecutionCo
498498
retryCount++;
499499
}
500500

501+
context.Output(StringUtil.Loc("DockerCommandFinalExitCode", command, exitCode));
501502
return exitCode;
502503
}
503504

src/Agent.Worker/ContainerOperationProvider.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1266,4 +1266,4 @@ private void PublishTelemetry(
12661266
publishTelemetryCmd.ProcessCommand(executionContext, cmd);
12671267
}
12681268
}
1269-
}
1269+
}

0 commit comments

Comments
 (0)