fix

Author: LiliDeng

lisa/notifiers/perfevaluation/perfevaluation.py

@@ -126,7 +126,7 @@ def evaluate(
     ) -> bool:
         """Evaluate if the actual value meets the criteria"""
         # Convert units if necessary
-        converted_value, conversion_info = self._convert_value_if_needed(actual_value)
+        converted_value, _ = self._convert_value_if_needed(actual_value)
         if converted_value is None:
             # Cannot convert - units incompatible
             return False
@@ -496,16 +496,19 @@ def _get_criteria_for_test(
                 metric_key = self._get_metric_key(metric_name, metric_unit)
                 if metric_key in best_match:
                     metric_criteria = best_match[metric_key]
-                    return MetricCriteria(
-                        min_value=metric_criteria.get("min_value"),
-                        max_value=metric_criteria.get("max_value"),
-                        target_value=metric_criteria.get("target_value"),
-                        tolerance_percent=metric_criteria.get("tolerance_percent"),
-                    )
+                    if isinstance(metric_criteria, dict):
+                        return MetricCriteria(
+                            min_value=metric_criteria.get("min_value"),
+                            max_value=metric_criteria.get("max_value"),
+                            target_value=metric_criteria.get("target_value"),
+                            tolerance_percent=metric_criteria.get("tolerance_percent"),
+                        )
         else:
             # Legacy format - direct metric lookup
             if isinstance(test_criteria, dict) and metric_name in test_criteria:
-                return test_criteria[metric_name]
+                criteria_value = test_criteria[metric_name]
+                if isinstance(criteria_value, MetricCriteria):
+                    return criteria_value
 
         return None